Skip to content

Commit

Permalink
Feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
tmat committed Jan 15, 2025
1 parent 24a35d6 commit 846e4f8
Showing 1 changed file with 3 additions and 6 deletions.
9 changes: 3 additions & 6 deletions src/Workspaces/CoreTest/UtilityTest/IntervalTreeTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -307,9 +307,6 @@ public void TestSortedEnumerable2()
Assert.Equal(tree, [0, 1]);
}

public static bool SpansOverlapsWith((int start, int length) left, (int start, int length) right)
=> Math.Max(left.start, right.start) < Math.Min(left.start + left.length, right.start + right.length);

private void TestOverlapsAndIntersects(IList<Tuple<int, int, string>> spans)
{
foreach (var tree in CreateTrees(spans))
Expand All @@ -319,19 +316,19 @@ private void TestOverlapsAndIntersects(IList<Tuple<int, int, string>> spans)
{
for (var length = 1; length <= max; length++)
{
var span = (start, length);
var span = new TextSpan(start, length);

var set1 = new HashSet<string>(GetIntervalsThatOverlapWith(tree, start, length).Select(i => i.Item3));
var set2 = new HashSet<string>(spans.Where(t =>
{
return SpansOverlapsWith(span, (t.Item1, t.Item2));
return span.OverlapsWith(new TextSpan(t.Item1, t.Item2));
}).Select(t => t.Item3));
Assert.True(set1.SetEquals(set2));

var set3 = new HashSet<string>(GetIntervalsThatIntersectWith(tree, start, length).Select(i => i.Item3));
var set4 = new HashSet<string>(spans.Where(t =>
{
return SpansOverlapsWith(span, (t.Item1, t.Item2));
return span.IntersectsWith(new TextSpan(t.Item1, t.Item2));
}).Select(t => t.Item3));
Assert.True(set3.SetEquals(set4));
}
Expand Down

0 comments on commit 846e4f8

Please # to comment.