Tweak completion filtering behavior. #2 #16894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyrusNajmabadi
added
the
PR For Personal Review Only
CyrusNajmabadi
changed the title
CyrusNajmabadi
commented
Feb 2, 2017
| /// Completion was triggered with a request to commit if a unique item would be selected | ||
| /// (ctrl-space in Visual Studio). | ||
| /// </summary> | ||
| InvokeAndCommitIfUnique |
There was a problem hiding this comment.
Feedback welcome on the names 'Invoke' and 'InvokeAndCommitIfUnique'.
There was a problem hiding this comment.
The VS commands are called list members and complete word. I like complete word but not list members.
|
tagging @dotnet/roslyn-ide This simplifies some of our code around filtering completion lists, moving as much as possible to one location, and providing a very simple API with very few knobs for consumers to get wrong. |
CyrusNajmabadi
removed
the
PR For Personal Review Only
rchande
reviewed
Feb 3, 2017
| dismissIfEmptyAllowed: dismissIfEmptyAllowed); | ||
| } | ||
| } | ||
| //private void FilterToSomeOrAllItems(bool filterItems, bool dismissIfEmptyAllowed, CompletionFilterReason filterReason) |
There was a problem hiding this comment.
I think you're looking at an old review :)
rchande
reviewed
Feb 3, 2017
| // moved out of bounds of the items, then we'll dismiss. Also queue up an insertion. | ||
| // that way we go and filter things properly to ensure that the list contains the | ||
| // appropriate items. | ||
| sessionOpt.FilterModel(CompletionFilterReason.CaretPositionChanged, filterState: null); |
There was a problem hiding this comment.
nice, lots of cryptic flags removed.
rchande
approved these changes
Feb 3, 2017
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems?id=362890
This is a more extensive change thatn #16892. Here, we also remove the 'recheckCaretPosition' check since that can be inferred from a FilterReason of 'CaretPositionChanged'.