Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Reduce dependencies #36283

Merged

Conversation

JoeRobich
Copy link
Member

@JoeRobich JoeRobich commented Jun 10, 2019

A few issues were found when validating NuGet packages for the 16.2 preview2 release.

  1. It looks like Microsoft.CodeAnalysis.editorfeatures.common is missing from NuGet and is preventing me from installing Microsoft.VisualStudio.LanguageServices.3.2.0-beta2-final.nupkg as it is dependent on it. (Microsoft.VisualStudio.LanguageServices has added many new nuget dependencies  #30662)
  2. Also I’m getting this error on upgrade that Microsoft.CodeAnalysis.FlowAnalysis.Utilities is missing (from Microsoft.CodeAnalysis.Features) as well. We will publish the required packages to NuGet and unlist.

@tmat and @jasonmalinowski please take a look

@JoeRobich JoeRobich requested a review from a team as a code owner June 10, 2019 22:54
@JoeRobich JoeRobich requested a review from a team as a code owner June 11, 2019 21:18
@JoeRobich JoeRobich force-pushed the reduce-dependencies branch from a4d00eb to cd90555 Compare June 12, 2019 21:49
@JoeRobich
Copy link
Member Author

@jasonmalinowski Can you give this another look?

@JoeRobich
Copy link
Member Author

@tmat please take a look

Copy link
Member

@jasonmalinowski jasonmalinowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, and thanks for the comment!

@JoeRobich JoeRobich merged commit 3add467 into dotnet:release/dev16.2-preview2 Jun 14, 2019
Copy link
Member

@tmat tmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants