Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Include ExternalAccess.RazorCompiler in source build #67996

Merged
merged 1 commit into from
Apr 27, 2023

Conversation

jjonescz
Copy link
Member

The project will be used by Razor source generator which is source-built, hence this project also needs to be source-built. See dotnet/razor#8242 (comment).

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead labels Apr 27, 2023
@jjonescz jjonescz requested review from jaredpar and chsienki April 27, 2023 08:34
@jjonescz jjonescz marked this pull request as ready for review April 27, 2023 11:40
@jjonescz jjonescz requested a review from a team as a code owner April 27, 2023 11:40
@jaredpar jaredpar merged commit 6d4997f into dotnet:main Apr 27, 2023
@ghost ghost added this to the Next milestone Apr 27, 2023
@jjonescz jjonescz deleted the EA-RazorCompiler-SourceBuild branch April 28, 2023 08:04
333fred added a commit to 333fred/roslyn that referenced this pull request May 2, 2023
* upstream/main: (2060 commits)
  implement code folding for anonymous objects
  Cleanup/perf in creating member maps. (dotnet#67997)
  Address feedback, clean the use of ILegacyGlobalOptionsWorkspaceService
  Update Publish.json
  Semantic snippets: Add inline statement snippets (dotnet#67819)
  Update VSSDK Build tools version
  Update doc comment
  Address feedback
  Move declaration near reference
  Address feedback
  Avoid stack overflow due to deep recursion on long chain of calls. (dotnet#67913)
  Check ILegacyGlobalOptionsWorkspaceService is null
  test scout queue
  add test
  update editor
  "Where" clause typo fix (dotnet#68002)
  Use `Keyword` helper method instead of hardcoding keyword help terms
  Move the SyntaxTree and SemanticModel action based analyzers to respect context.FilterSpan
  EnC refactoring: Align wrappers with contracts better (dotnet#67967)
  Include EA.RazorCompiler in source build (dotnet#67996)
  ...
@Cosifne Cosifne modified the milestones: Next, 17.7 P2 May 31, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants