Improve fix-all progress bar experience #73412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
CyrusNajmabadi
commented
May 9, 2024
| if (value.ClearValue) | ||
| { | ||
| Interlocked.Exchange(ref _totalItems, 0); | ||
| Interlocked.Exchange(ref _completedItems, 0); |
There was a problem hiding this comment.
whoops. we just lost this in a prior refactoring in this space.
CyrusNajmabadi
commented
May 9, 2024
| @@ -1466,6 +1467,7 @@ internal virtual bool TryApplyChanges(Solution newSolution, IProgress<CodeAnalys | |||
|
|
|||
| foreach (var projectChanges in projectChangesList) | |||
| { | |||
| progressTracker.Report(CodeAnalysisProgress.Description(string.Format(WorkspacesResources.Applying_changes_to_0, projectChanges.NewProject.Name))); | |||
There was a problem hiding this comment.
now, when we're doing the actual application of hte changes to the workspace, you now see progress for that as well.
CyrusNajmabadi
commented
May 9, 2024
| @@ -165,6 +165,7 @@ private async Task InvokeWorkerAsync(IProgress<CodeAnalysisProgress> progressTra | |||
| // Clear the progress we showed while computing the action. | |||
| // We'll now show progress as we apply the action. | |||
| progressTracker.Report(CodeAnalysisProgress.Clear()); | |||
| progressTracker.Report(CodeAnalysisProgress.Description(EditorFeaturesResources.Applying_changes)); | |||
There was a problem hiding this comment.
Now, after cleanup, and selecting "apply" we actually "Applying changes" :)
So user sees 3 passes.
First: Gettins the initial fixes.
Second: Cleaning them.
Third: Applying them to workspace.
ToddGrun
reviewed
May 9, 2024
| @@ -11,6 +11,7 @@ | |||
| using System.Threading; | |||
| using System.Threading.Tasks; | |||
| using Microsoft.CodeAnalysis; | |||
| using Microsoft.CodeAnalysis.CodeActions; | |||
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FixALlProgressSmall.mp4