Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Verify that ref-in-async errors are not downgraded to warnings in unsafe context #73490

Merged
merged 1 commit into from
May 17, 2024

Conversation

jjonescz
Copy link
Member

@jjonescz jjonescz commented May 15, 2024

Related to test plan: #72662

Should address this part of the test plan:

  • use ref / ref struct local
    • error in async / iterator even in unsafe context

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels May 15, 2024
@jjonescz jjonescz marked this pull request as ready for review May 15, 2024 16:10
@jjonescz jjonescz requested a review from a team as a code owner May 15, 2024 16:10
@jjonescz jjonescz requested review from AlekseyTs and cston May 15, 2024 16:11
Copy link
Contributor

@AlekseyTs AlekseyTs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (commit 1)

@jjonescz jjonescz merged commit 05e5ec7 into dotnet:main May 17, 2024
24 checks passed
@jjonescz jjonescz deleted the RefInAsync-07-Tests branch May 17, 2024 07:55
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone May 17, 2024
@Cosifne Cosifne modified the milestones: Next, 17.11 P2 May 28, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Area-Compilers Feature - Ref/Unsafe in Iterators/Async untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants