Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Switch to work queue for code definition window #73723

Merged
merged 4 commits into from
May 26, 2024

Conversation

CyrusNajmabadi
Copy link
Member

Addresses lots of unnecessary exceptions thrown during normal scrolling scenarios (99% of all vs exceptions!)

image

@CyrusNajmabadi CyrusNajmabadi requested a review from ToddGrun May 26, 2024 19:02
@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner May 26, 2024 19:02
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels May 26, 2024
@CyrusNajmabadi
Copy link
Member Author

@ToddGrun ptal

@@ -95,67 +107,47 @@ private void QueueUpdateForCaretPosition(CaretPosition caretPosition)
{
Contract.ThrowIfFalse(_threadingContext.JoinableTaskContext.IsOnMainThread);

// Cancel any pending update for this view
_currentUpdateCancellationToken?.Cancel();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_currentUpdateCancellationToken?.Cancel();

Much nicer now!

Copy link
Contributor

@ToddGrun ToddGrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants