Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix issue where we were querying a linq expression over and over #73750

Merged
merged 5 commits into from
May 29, 2024
Merged

Fix issue where we were querying a linq expression over and over #73750

merged 5 commits into from
May 29, 2024

Conversation

CyrusNajmabadi
Copy link
Member

Fixes 0.3% of allocs:

image

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner May 28, 2024 22:31
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels May 28, 2024
CyrusNajmabadi
CyrusNajmabadi commented May 28, 2024
View reviewed changes
...Workspaces/SharedUtilitiesAndExtensions/Workspace/Core/Workspace/Mef/MefWorkspaceServices.cs Outdated
var list = _exportProvider.GetExports<ILanguageService, LanguageServiceMetadata>().Select(lz => lz.Metadata.Language).Concat(
_exportProvider.GetExports<ILanguageServiceFactory, LanguageServiceMetadata>().Select(lz => lz.Metadata.Language))
.Distinct()
.ToImmutableArray();
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops.

ToddGrun
ToddGrun approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@ToddGrun ToddGrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@CyrusNajmabadi CyrusNajmabadi enabled auto-merge May 28, 2024 22:40
@build-analysis build-analysis bot mentioned this pull request May 29, 2024
Open
3 tasks
@CyrusNajmabadi CyrusNajmabadi merged commit 9d15715 into dotnet:main May 29, 2024
25 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone May 29, 2024
@CyrusNajmabadi CyrusNajmabadi deleted the distinctIterator branch May 29, 2024 18:56
This was referenced Jun 4, 2024
Closed
Closed
Closed
@jjonescz jjonescz modified the milestones: Next, 17.11 P3 Jun 24, 2024
@dotnet-bot dotnet-bot mentioned this pull request Jun 27, 2024
Closed
@dibarbet dibarbet mentioned this pull request Jul 25, 2024
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ToddGrun ToddGrun ToddGrun approved these changes

Assignees
No one assigned
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
17.11 P3
Development

Successfully merging this pull request may close these issues.
3 participants
@CyrusNajmabadi @ToddGrun @jjonescz