Use separate async tracker for SG work instad of reusing workspace async tracker #73880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
CyrusNajmabadi
force-pushed
the
sgWait
branch
2 times, most recently
from
42154ab to
ddffabf
Compare
…ync tracker No need to wait to be fully loaded. all we're doing is incrementing numbers, not actually running generators
|
test insertion for main |
genlu
approved these changes
Jun 7, 2024
|
If this passes, it indicates a serious bug in the usage of what is now on the SG async tracker. We should definitely fix that. The idea behind the expedited waiter is it forces all time-based waiting items to complete immediately. If this involves items waiting for something other than a timeout, we should find a way to resolve it consistently. |
This was referenced Jun 12, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build; https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=9693099&view=results