Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Disallow span conversions between spans which are not structs #74587

Merged
merged 2 commits into from
Aug 2, 2024
Merged

Disallow span conversions between spans which are not structs #74587

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0a7bf36
Disallow span conversions between spans which are not structs
jjonescz Jul 29, 2024
e2d9d92
Require ref struct
jjonescz Aug 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/Compilers/CSharp/Portable/Symbols/TypeSymbolExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1343,6 +1343,8 @@ internal static bool IsSpan(this TypeSymbol type)
return type is NamedTypeSymbol
{
Name: "Span",
IsValueType: true,
IsRefLikeType: true,
Arity: 1,
ContainingType: null,
ContainingNamespace: { Name: nameof(System), ContainingNamespace.IsGlobalNamespace: true },
Expand All @@ -1354,6 +1356,8 @@ internal static bool IsReadOnlySpan(this TypeSymbol type)
return type is NamedTypeSymbol
{
Name: "ReadOnlySpan",
IsValueType: true,
IsRefLikeType: true,
Arity: 1,
ContainingType: null,
ContainingNamespace: { Name: nameof(System), ContainingNamespace.IsGlobalNamespace: true },
Expand Down
22 changes: 22 additions & 0 deletions src/Compilers/CSharp/Test/Emit3/FirstClassSpanTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,6 +344,28 @@ public readonly ref struct Span<T>
Diagnostic(ErrorCode.ERR_MissingPredefinedMember, "arr()").WithArguments("System.Span<T>", "op_Implicit").WithLocation(2, 15));
}

[Theory, CombinatorialData]
public void Conversion_Array_Span_Implicit_SpanNotRefStruct(
[CombinatorialValues("class", "struct", "readonly struct", "record", "record struct", "readonly record struct")] string kind,
[CombinatorialValues("Span", "ReadOnlySpan")] string type)
{
var source = $$"""
using System;
{{type}}<int> s =
arr();
static int[] arr() => new int[] { 1, 2, 3 };

namespace System
{
public {{kind}} {{type}}<T>;
}
""";
CreateCompilation(source).VerifyDiagnostics(
// (3,5): error CS0029: Cannot implicitly convert type 'int[]' to 'System.Span<int>'
// arr();
Diagnostic(ErrorCode.ERR_NoImplicitConv, "arr()").WithArguments("int[]", $"System.{type}<int>").WithLocation(3, 5));
}

[Theory, CombinatorialData]
public void Conversion_Array_Span_Implicit_DifferentOperator(
[CombinatorialValues("int[]", "T[][]")] string parameterType)
Expand Down