Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Use manual foreach instead of AddRange method for certain collection expression spreads #74630

Merged
merged 9 commits into from
Aug 14, 2024
Merged

Use manual foreach instead of AddRange method for certain collection expression spreads #74630

merged 9 commits into from
Aug 14, 2024

Conversation

DoctorKrolic
Copy link
Contributor

Fixes: #74615

@DoctorKrolic
Use manual foreach instead of AddRange method when collection typ…
15ce34d 
…e of spreading element doesn't implement `ICollection<T>`, but has a `struct` enumerator
@DoctorKrolic DoctorKrolic requested a review from a team as a code owner August 1, 2024 12:17
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels Aug 1, 2024
@dotnet-policy-service dotnet-policy-service bot added the Community The pull request was submitted by a contributor who is not a Microsoft employee. label Aug 1, 2024
@build-analysis build-analysis bot mentioned this pull request Aug 5, 2024
Open
5 tasks
@DoctorKrolic
Copy link
Contributor Author

@RikkiGibson @cston PTAL

@RikkiGibson RikkiGibson self-assigned this Aug 12, 2024
@RikkiGibson RikkiGibson requested a review from a team August 13, 2024 20:45
@DoctorKrolic DoctorKrolic requested a review from cston August 14, 2024 19:20
@DoctorKrolic DoctorKrolic requested a review from cston August 14, 2024 19:37
@cston cston merged commit e1496f4 into dotnet:main Aug 14, 2024
24 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Aug 14, 2024
@cston
Copy link
Member

cston commented Aug 14, 2024

Thanks @DoctorKrolic.

@DoctorKrolic DoctorKrolic deleted the collection-expressions-use-manual-foreach branch August 15, 2024 05:24
@DoctorKrolic DoctorKrolic mentioned this pull request Aug 15, 2024
Merged
This was referenced Aug 21, 2024
Closed
Closed
@cston cston mentioned this pull request Aug 24, 2024
Closed
@dibarbet dibarbet modified the milestones: Next, 17.12 P2 Aug 26, 2024
@dotnet-bot dotnet-bot mentioned this pull request Aug 28, 2024
Closed
@cston cston mentioned this pull request Aug 29, 2024
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@RikkiGibson RikkiGibson RikkiGibson approved these changes

@cston cston cston approved these changes

Assignees

@RikkiGibson RikkiGibson

Labels
Area-Compilers Community The pull request was submitted by a contributor who is not a Microsoft employee. untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
17.12 P2
Development

Successfully merging this pull request may close these issues.

Collection expressions use AddRange instead of manual foreach in presence of a struct enumerator
4 participants
@DoctorKrolic @cston @RikkiGibson @dibarbet