-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Always take ownership from UIThreadContext when rename commit #74889
Merged
Cosifne
merged 10 commits into
dotnet:main
from
Cosifne:dev/shech/TakeOnwershipWhenRename
Aug 28, 2024
Merged
Always take ownership from UIThreadContext when rename commit #74889
Cosifne
merged 10 commits into
dotnet:main
from
Cosifne:dev/shech/TakeOnwershipWhenRename
Aug 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/EditorFeatures/Core/InlineRename/CommandHandlers/AbstractRenameCommandHandler.cs
Outdated
Show resolved
Hide resolved
...itorFeatures/Core/InlineRename/CommandHandlers/AbstractRenameCommandHandler_RenameHandler.cs
Outdated
Show resolved
Hide resolved
...EditorFeatures/Core/InlineRename/CommandHandlers/AbstractRenameCommandHandler_SaveHandler.cs
Outdated
Show resolved
Hide resolved
CyrusNajmabadi
approved these changes
Aug 26, 2024
src/EditorFeatures/Core/InlineRename/CommandHandlers/AbstractRenameCommandHandler.cs
Outdated
Show resolved
Hide resolved
3 tasks
This was referenced Sep 6, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current build, if the rename commit takes long time, when the commit is not triggered by 'enter'.
Your won't be able to cancel the operation.
Before:

After:

It happens when I type 'ctrl + s' to commit the rename.
Fix is always taking ownership from the UIContext when commit starts.
We already do this in enter command handler,
roslyn/src/EditorFeatures/Core/InlineRename/CommandHandlers/AbstractRenameCommandHandler_ReturnHandler.cs
Line 22 in f915125
Later rename session would choose to use IUIThreadOperationContext or IBackgroundIndicator by itself.