Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Added LSP support for document color requests #74933

Merged
merged 3 commits into from
Aug 29, 2024

Conversation

mgoertz-msft
Copy link
Contributor

@mgoertz-msft mgoertz-msft commented Aug 28, 2024

  • Updated LSP protocol types for document color support
  • Updated EA.Xaml to allow external client capability checks

- Updated EX.Xaml to allow external client capability checks
@mgoertz-msft mgoertz-msft requested a review from a team as a code owner August 28, 2024 19:04
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Aug 28, 2024
@dotnet-policy-service dotnet-policy-service bot added Community The pull request was submitted by a contributor who is not a Microsoft employee. VSCode labels Aug 28, 2024
@dibarbet
Copy link
Member

@mgoertz-msft FYI some merge conflicts (probably b/c of a recent change to add all the 3.17 LSP types).

@mgoertz-msft
Copy link
Contributor Author

Yeah, I noticed that as soon as I created it. :(

@mgoertz-msft
Copy link
Contributor Author

@dibarbet Resolved. I was able to just take everything from Main. Only EA.Xaml changes left now. :)

cc @etvorun

@mgoertz-msft
Copy link
Contributor Author

@dibarbet Looks like infrastructure errors now. There are no test failures on the Azure pipelines.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee. untriaged Issues and PRs which have not yet been triaged by a lead VSCode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants