Revert "Load analyzers and generators in isolated ALCs in our OOP process" #74985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
|
What exceptions are you running into? |
|
@dibarbet as well. We sent this pr through speedometer, and it passed. So it's unclear why we'd hit an issue now. |
Unfortunately, your validation PR didn't pass speedometer. There was an infra issue, and it didn't run:
There are lots of filenotfound and unauthorizedaccess exceptions when attempting to load various generators in speedometer, we're reverting for expediency. |
genlu
approved these changes
Sep 4, 2024
|
I'm super confused. I got a pass notification. I even copied it... Ugh. |
That was just the DDRIT test run passing, not the Speedometer, unfortunately. |
This was referenced Sep 6, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #74780. Running into exceptions in speedometer and blocking VS insertions.