Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Do not pin the Compilers.Toolset version #75488

Merged
merged 3 commits into from
Oct 14, 2024
Merged

Do not pin the Compilers.Toolset version #75488

merged 3 commits into from
Oct 14, 2024

Conversation

RikkiGibson
Copy link
Contributor

No description provided.

@RikkiGibson RikkiGibson requested a review from a team as a code owner October 11, 2024 21:04
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead labels Oct 11, 2024
@RikkiGibson
Copy link
Contributor Author

I'm suspicious that something is still pinning the toolset version, will check the binlog.

@RikkiGibson
Copy link
Contributor Author

@jaredpar @dotnet/roslyn-infrastructure for review

jaredpar
jaredpar approved these changes Oct 14, 2024
View reviewed changes
Copy link
Member

@jaredpar jaredpar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved assuming we are green.

@RikkiGibson RikkiGibson merged commit 1772666 into main Oct 14, 2024
28 checks passed
@RikkiGibson RikkiGibson deleted the dev/rigibson/remove-toolset branch October 14, 2024 21:17
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Oct 14, 2024
This was referenced Oct 22, 2024
Closed
Closed
@akhera99 akhera99 modified the milestones: Next, 17.13 P1 Oct 28, 2024
@dotnet-bot dotnet-bot mentioned this pull request Oct 29, 2024
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jaredpar jaredpar jaredpar approved these changes

Assignees
No one assigned
Labels
Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
17.13 P1
Development

Successfully merging this pull request may close these issues.
3 participants
@RikkiGibson @jaredpar @akhera99