Add ETW events when ALCs are created or disposed #75550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Compilers
untriaged
chsienki
reviewed
Oct 17, 2024
src/Compilers/Core/Portable/DiagnosticAnalyzer/AnalyzerAssemblyLoader.Core.cs
Outdated
Show resolved
Hide resolved
chsienki
approved these changes
Oct 17, 2024
CyrusNajmabadi
approved these changes
Oct 17, 2024
|
I believe I am not causing the integration test failures, as different tests are failing in each attempt on different issues: once a lightbulb being unexpectedly dismissed, another an NRE in TestTraceListener. |
RikkiGibson
commented
Oct 23, 2024
| @@ -40,6 +40,7 @@ | |||
| <Compile Include="..\..\..\Compilers\Core\Portable\DiagnosticAnalyzer\DefaultAnalyzerAssemblyLoader.cs" Link="Diagnostics\CompilerShared\DefaultAnalyzerAssemblyLoader.cs" /> | |||
| <Compile Include="..\..\..\Compilers\Core\Portable\DiagnosticAnalyzer\ShadowCopyAnalyzerAssemblyLoader.cs" Link="Diagnostics\CompilerShared\ShadowCopyAnalyzerAssemblyLoader.cs" /> | |||
| <Compile Include="..\..\..\Compilers\Core\Portable\DiagnosticAnalyzer\IAnalyzerAssemblyResolver.cs" Link="Diagnostics\CompilerShared\IAnalyzerAssemblyResolver.cs" /> | |||
| <Compile Include="..\..\..\Compilers\Core\Portable\CodeAnalysisEventSource.cs" Link="Diagnostics\CompilerShared\CodeAnalysisEventSource.cs" /> | |||
There was a problem hiding this comment.
I suspect that this source-include of the CodeAnalysisEventSource is causing regression https://dev.azure.com/devdiv/DevDiv/_workitems/edit/2289777
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to get more data about increase in allocs from #75233.
@jaredpar @CyrusNajmabadi
Appears to be working when compiling Microsoft.CodeAnalysis thru PerfView. I am assuming that merely compiling does not actually go thru the teardown process, so the lack of Stop events is not a surprise.
