Don't allocate while walking a NormalizedSnapshotSpanCollection during classification tagging #75631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g classification tagging Saw this in a scrolling speedometer profile, only 0.3%, but it's trivial to remove. They don't publicly expose a struct based enumerator, but they do expose an indexer, so it's easy enough to use that to walk over the collection.
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
sandyarmstrong
approved these changes
Oct 25, 2024
CyrusNajmabadi
approved these changes
Oct 25, 2024
This was referenced Oct 30, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saw this in a scrolling speedometer profile, only 0.3%, but it's trivial to remove. They don't publicly expose a struct based enumerator, but they do expose an indexer, so it's easy enough to use that to walk over the collection.
*** allocations from speedometer scrolling profile that should be removed by this change ***
