Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Ref safety: replace uint scope with struct SafeContext #75647

Merged
merged 15 commits into from
Nov 8, 2024

Update src/Compilers/CSharp/Portable/Binder/Binder_Operators.cs

e97c428
Select commit
Loading
Failed to load commit list.
Merged

Ref safety: replace uint scope with struct SafeContext #75647

Update src/Compilers/CSharp/Portable/Binder/Binder_Operators.cs
e97c428
Select commit
Loading
Failed to load commit list.
Build Analysis / Build Analysis failed Nov 8, 2024 in 0s

.NET Result Analysis

Details

Tip

To unconditionally bypass the build analysis check (turn it green), you can use the escape mechanism feature. The completion time may vary, potentially taking several minutes, depending on the build analysis workload at the moment.

Test Failures (3 tests failed)

🔹 [All failing tests from roslyn-CI]

    Microsoft.CodeAnalysis.Editor.UnitTests.IntelliSense.VisualBasicCompletionCommandHandlerTests.TestMatchWithTurkishIWorkaround10 [Console] [Details] [Artifacts] [1.57% failure rate]
    [ 🚧 Report test infrastructure issue] [ 📄 Report test repository issue]

    Failing Configuration

    Exception Message
    Assert.Equal() Failure: Strings differ
                ↓ (pos 1)
    Expected: "If"
    Actual:   "ICustomFormatter"
                ↑ (pos 1)
    CallStack
       at Microsoft.CodeAnalysis.Editor.UnitTests.IntelliSense.TestState.VB$StateMachine_50_AssertSelectedCompletionItem.MoveNext() in /_/src/EditorFeatures/TestUtilities2/Intellisense/TestState.vb:line 470
    --- End of stack trace from previous location where exception was thrown ---
       at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
       at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
       at Microsoft.CodeAnalysis.Editor.UnitTests.IntelliSense.VisualBasicCompletionCommandHandlerTests.VB$StateMachine_156_TestMatchWithTurkishIWorkaround10.MoveNext() in /_/src/EditorFeatures/Test2/IntelliSense/VisualBasicCompletionCommandHandlerTests.vb:line 3193
    --- End of stack trace from previous location where exception was thrown ---
       at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
       at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
       at System.Runtime.CompilerServices.TaskAwaiter.ValidateEnd(Task task)
    --- End of stack trace from previous location where exception was thrown ---
       at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
       at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
    --- End of stack trace from previous location where exception was thrown ---
       at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
       at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
    Microsoft.CodeAnalysis.Editor.UnitTests.IntelliSense.VisualBasicCompletionCommandHandlerTests.TestMatchWithTurkishIWorkaround9 [Console] [Details] [Artifacts] [6.35% failure rate]
    [ 🚧 Report test infrastructure issue] [ 📄 Report test repository issue]

    Failing Configuration

    Exception Message
    Assert.Equal() Failure: Strings differ
                ↓ (pos 1)
    Expected: "If"
    Actual:   "ICustomFormatter"
                ↑ (pos 1)
    CallStack
       at Microsoft.CodeAnalysis.Editor.UnitTests.IntelliSense.TestState.VB$StateMachine_50_AssertSelectedCompletionItem.MoveNext() in /_/src/EditorFeatures/TestUtilities2/Intellisense/TestState.vb:line 470
    --- End of stack trace from previous location where exception was thrown ---
       at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
       at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
       at Microsoft.CodeAnalysis.Editor.UnitTests.IntelliSense.VisualBasicCompletionCommandHandlerTests.VB$StateMachine_155_TestMatchWithTurkishIWorkaround9.MoveNext() in /_/src/EditorFeatures/Test2/IntelliSense/VisualBasicCompletionCommandHandlerTests.vb:line 3168
    --- End of stack trace from previous location where exception was thrown ---
       at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
       at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
       at System.Runtime.CompilerServices.TaskAwaiter.ValidateEnd(Task task)
    --- End of stack trace from previous location where exception was thrown ---
       at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
       at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
    --- End of stack trace from previous location where exception was thrown ---
       at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
       at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
    Microsoft.CodeAnalysis.EditorFeatures2.UnitTests_50.WorkItemExecution [Console] [Details] [Artifacts] [26.40% failure rate]
    [ 🚧 Report test infrastructure issue] [ 📄 Report test repository issue]
    This is a helix work item crash with status: BadExit. To investigate look the [Console log] / navigate to [Helix Artifacts]

    Failing Configuration

Was this helpful? Yes No