Check for BackingField instead of IsAutoProperty in NullableWalker #75872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Compilers
untriaged
RikkiGibson
changed the title
getFieldSymbolToBeInitialized
This comment was marked as resolved.
This comment was marked as resolved.
RikkiGibson
changed the title
getFieldSymbolToBeInitializedNullableWalker.Scan.getFieldSymbolToBeInitialized
RikkiGibson
changed the title
NullableWalker.Scan.getFieldSymbolToBeInitialized
cston
approved these changes
Nov 21, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #75245
It looks like this function is still needed for some complex cases involving required properties, MemberNotNull applied to setters, and constructor chaining. I adjusted the function to behave correctly with properties using the field keyword as well.
It looks like this function is no longer needed because we recently added a mechanism to share a slot between property and backing field under appropriate conditions. Specifically, changes toNullableWalker.GetOrCreateSlotin #75246.