Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Workaround failing official builds #75898

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Conversation

jjonescz
Copy link
Member

Related: dotnet/dnceng#4441
Official build run of this PR: https://dev.azure.com/dnceng/internal/_build/results?buildId=2581358&view=results

No idea why, but when the eng/common/internal/Tools.csproj project is being restored as part of the "restore internal tools", it works with the arcade-provided NuGet feeds. But when that same project is being restored as part of the "build" step, it reports 401 (Unauthorized) for the visualstudio.com feeds - replacing them with the azure.com equivalents fixes the problem.

(Note that technically the second restore of that project as part of the build step is unnecessary, but I didn't find a simple way to disable it.)

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead labels Nov 13, 2024
@arunchndr arunchndr marked this pull request as ready for review November 13, 2024 20:28
@arunchndr arunchndr requested a review from a team as a code owner November 13, 2024 20:28
@jjonescz jjonescz enabled auto-merge (squash) November 13, 2024 20:52
@jjonescz jjonescz merged commit c0556d2 into dotnet:main Nov 13, 2024
28 checks passed
@jjonescz jjonescz deleted the restore401 branch November 13, 2024 21:22
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Nov 13, 2024
JoeRobich pushed a commit that referenced this pull request Nov 20, 2024
jaredpar pushed a commit that referenced this pull request Nov 20, 2024
Co-authored-by: Jan Jones <jan.jones.cz@gmail.com>
@jjonescz jjonescz modified the milestones: Next, 17.13 P2 Nov 25, 2024
jjonescz added a commit to jjonescz/roslyn that referenced this pull request Nov 25, 2024
jjonescz added a commit to jjonescz/roslyn that referenced this pull request Nov 25, 2024
jjonescz added a commit that referenced this pull request Nov 26, 2024
* Workaround failing official builds (#75898)

* Update structured logger (#75865)

Upgrade to latest structured logger binaries and see if that addresses the failure to read binary logs.

---------

Co-authored-by: Jared Parsons <jared@paranoidcoding.org>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants