Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Postpone respecting the code-style analysis config rule until NET10 #75978

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

arunchndr
Copy link
Member

@arunchndr arunchndr commented Nov 19, 2024

Related to #71173

Until we can connect the dots better for the user that has analysislevel set to latest-all (which currently is a lot of users), that this is the exact action and result that caused these errors in the IDE and cmdline, lets postpone enabling this.

Until we can connect the dots better for the user that has analysislevel set to latest-all (which currently is a lot of users), that this is the exact action and result that caused these errors in the IDE and cmdline, lets postpone enabling this.
@arunchndr arunchndr requested a review from a team as a code owner November 19, 2024 21:59
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead labels Nov 19, 2024
@arunchndr arunchndr enabled auto-merge November 19, 2024 22:01
@arunchndr arunchndr disabled auto-merge November 19, 2024 22:04
@arunchndr arunchndr changed the title Postpone the code-style analysis config rule until NET10 Postpone respecting the code-style analysis config rule until NET10 Nov 19, 2024
@arunchndr
Copy link
Member Author

LGTM! @JoeRobich feel free to hit merge when ready. We may need a rebase or cherry pick to 17.12.

@JoeRobich JoeRobich merged commit d88be6d into main Nov 20, 2024
25 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Nov 20, 2024
arunchndr added a commit that referenced this pull request Nov 20, 2024
…til NET10 (#75984)

Back ports the changes from #75978

Related to #71173

Until we can connect the dots better for the user that has analysislevel
set to latest-all (which currently is a lot of users), that this is the
exact action and result that caused these errors in the IDE and cmdline,
lets postpone enabling this.
@jjonescz jjonescz modified the milestones: Next, 17.13 P2 Nov 25, 2024
@JoeRobich JoeRobich deleted the arunchndr-patch-1 branch December 20, 2024 18:57
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead VSCode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants