Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Mark used deconstruct methods. #76012

Merged
merged 3 commits into from
Nov 21, 2024
Merged

Mark used deconstruct methods. #76012

merged 3 commits into from
Nov 21, 2024

Conversation

CyrusNajmabadi
Copy link
Member

Fixes #75995

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner November 21, 2024 20:43
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Nov 21, 2024
ToddGrun
ToddGrun approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@ToddGrun ToddGrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@CyrusNajmabadi CyrusNajmabadi merged commit 6963ba3 into dotnet:main Nov 21, 2024
25 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Nov 21, 2024
@CyrusNajmabadi CyrusNajmabadi deleted the unusedDeconstruct branch November 21, 2024 22:09
jcouv
jcouv reviewed Nov 22, 2024
View reviewed changes
...nalyzers/Core/Analyzers/RemoveUnusedMembers/AbstractRemoveUnusedMembersDiagnosticAnalyzer.cs
}
}
}

private void AnalyzeDeconstructionAssignment(OperationAnalysisContext operationContext)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is likely another similar scenario, which is foreach-deconstruction: foreach (var (x, y) in ...). There's another semantic model API for that one (DeconstructionInfo GetDeconstructionInfo(ForEachVariableStatementSyntax node)).

@dotnet-bot dotnet-bot mentioned this pull request Nov 25, 2024
Closed
@jjonescz jjonescz modified the milestones: Next, 17.13 P2 Nov 25, 2024
@dotnet-bot dotnet-bot mentioned this pull request Nov 26, 2024
Closed
@dotnet-bot dotnet-bot mentioned this pull request Dec 14, 2024
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jcouv jcouv jcouv left review comments

@ToddGrun ToddGrun ToddGrun approved these changes

Assignees
No one assigned
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead VSCode
Projects
None yet
Milestone
17.13 P2
Development

Successfully merging this pull request may close these issues.

Incorrect diagnostic that Deconstruct method is unused.
4 participants
@CyrusNajmabadi @ToddGrun @jcouv @jjonescz