Update Copilot rename telemetry #76045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
dotnet-policy-service
bot
added
the
Community
Cosifne
reviewed
Nov 25, 2024
| @@ -93,6 +95,7 @@ private ISmartRenameSessionWrapper(object instance) | |||
| public string StatusMessage => s_statusMessageAccessor(_instance); | |||
| public bool StatusMessageVisibility => s_statusMessageVisibilityAccessor(_instance); | |||
| public IReadOnlyList<string> SuggestedNames => s_suggestedNamesAccessor(_instance); | |||
| public Guid CorrelationId => s_correlationIdAccessor(_instance); | |||
There was a problem hiding this comment.
Looks like we need to insert editor change first
|
Change looks good, but we might want to wait 17.13 P2 to merge this in |
|
Thanks for the review. That's in line with my expectations, let's merge in December. |
Cosifne
approved these changes
Dec 3, 2024
Cosifne
added a commit
that referenced
this pull request
Dec 7, 2024
Just noticed that recent telemetry change #76045 uses Timestamp to report delay, e.g. `00:00:00.0006369`. Processing timestamp is expensive. I'm updating telemetry to use `double TotalMillseconds`, e.g. `68.9512` (sic, this example is pasted from a different measurement)
This was referenced Dec 11, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Copilot rename telemetry with the following information: