Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Properly update return type when updating method. #76157

Merged
merged 5 commits into from
Nov 30, 2024
Merged

Properly update return type when updating method. #76157

merged 5 commits into from
Nov 30, 2024

Conversation

CyrusNajmabadi
Copy link
Member

Fixes #55975

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner November 29, 2024 18:55
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Nov 29, 2024
CyrusNajmabadi
CyrusNajmabadi commented Nov 29, 2024
View reviewed changes
...e/Portable/Completion/Providers/ImportCompletionProvider/AbstractImportCompletionProvider.cs

// Add required using/imports directive.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extracted to helper class so it can be used by both completino providers.

@CyrusNajmabadi
Copy link
Member Author

@akhera99 @Cosifne ptal.

@CyrusNajmabadi CyrusNajmabadi merged commit 5213c18 into dotnet:main Nov 30, 2024
25 checks passed
@CyrusNajmabadi CyrusNajmabadi deleted the makeAsyncHelper branch November 30, 2024 17:05
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Nov 30, 2024
@CyrusNajmabadi CyrusNajmabadi changed the title Property update return type when updating method. Properly update return type when updating method. Nov 30, 2024
@dotnet-bot dotnet-bot mentioned this pull request Dec 4, 2024
Closed
This was referenced Dec 11, 2024
Closed
Closed
@dibarbet dibarbet modified the milestones: Next, 17.13 P3 Jan 7, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@akhera99 akhera99 akhera99 approved these changes

@Cosifne Cosifne Awaiting requested review from Cosifne

Assignees
No one assigned
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead VSCode
Projects
None yet
Milestone
17.13 P3
Development

Successfully merging this pull request may close these issues.

IDE automatically adds async keyword to methods without changing the return type
3 participants
@CyrusNajmabadi @akhera99 @dibarbet