Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Clamp selections within a string literal so they do not go outside of it #76163

Merged
merged 2 commits into from
Dec 2, 2024
Merged

Clamp selections within a string literal so they do not go outside of it #76163

merged 2 commits into from
Dec 2, 2024

Conversation

CyrusNajmabadi
Copy link
Member

Fixes #58774

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner November 29, 2024 22:50
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Nov 29, 2024
@build-analysis build-analysis bot mentioned this pull request Nov 30, 2024
Open
3 tasks
ToddGrun
ToddGrun reviewed Dec 2, 2024
View reviewed changes
src/EditorFeatures/CSharp/TextStructureNavigation/CSharpTextStructureNavigatorProvider.cs
if (CharAt(contentEnd - 1) == '8')
contentEnd--;

if (CharAt(contentEnd - 1) is 'u' or 'U')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if (CharAt(contentEnd - 1) is 'u' or 'U')

maybe combine this with the previous one since they are only valid in combination, right?

ToddGrun
ToddGrun approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@ToddGrun ToddGrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@CyrusNajmabadi CyrusNajmabadi merged commit 6b87d0e into dotnet:main Dec 2, 2024
25 checks passed
@CyrusNajmabadi CyrusNajmabadi deleted the textNavigation branch December 2, 2024 21:28
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Dec 2, 2024
@dotnet-bot dotnet-bot mentioned this pull request Dec 4, 2024
Closed
This was referenced Dec 11, 2024
Closed
Closed
@dibarbet dibarbet modified the milestones: Next, 17.13 P3 Jan 7, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ToddGrun ToddGrun ToddGrun approved these changes

Assignees
No one assigned
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
17.13 P3
Development

Successfully merging this pull request may close these issues.

Double click to select string results in selection outside of string
3 participants
@CyrusNajmabadi @ToddGrun @dibarbet