Do not duplicate directives when converting from property to methods #76184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
ToddGrun
reviewed
Dec 3, 2024
| @@ -1738,13 +1748,6 @@ internal interface ILanguageServiceHost | |||
| /// An value that provides access to the language service for the active configured project. | |||
| /// </returns> | |||
| object GetActiveProjectContext(); | |||
|
|
|||
| /// <summary> | |||
There was a problem hiding this comment.
yeah, i thought about it, but decided it was something the user would need to take care of to decide how they wanted the existing comment to map over to multiple members.
ToddGrun
reviewed
Dec 3, 2024
| CancellationToken cancellationToken) | ||
| { | ||
| var methodDeclaration = GetSetMethodWorker(); | ||
|
|
||
| // The analyzer doesn't report diagnostics when the trivia contains preprocessor directives, so it's safe | ||
| // to copy the complete leading trivia to both generated methods. |
There was a problem hiding this comment.
Did this comment used to be true? It seems like the code was written with consideration to pp directives, so I'm curious where it went wrong.
There was a problem hiding this comment.
yeah. that comment looks to be a big fat lie. it might have been true way in the past. :)
This was referenced Dec 11, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #75186