Report errors processing messages from the build host #76252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
dibarbet
commented
Dec 4, 2024
| } | ||
| catch (JsonException ex) | ||
| { | ||
| var message = $"Failed to deserialize response from build host:{Environment.NewLine}{line}"; |
There was a problem hiding this comment.
needed to include the specific string that failed to deserialize
dibarbet
changed the title
|
@jasonmalinowski ptal. Tnx |
jasonmalinowski
approved these changes
Dec 4, 2024
This was referenced Dec 12, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #75967
Previously, any errors processing messages would just cause an inifnite hang. This is updates the implementation to do two things