Add support for getting debugger data tips through LSP. #76285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
CyrusNajmabadi
commented
Dec 5, 2024
| { | ||
| private static async Task TestAsync(string markup, string expectedText = null) |
There was a problem hiding this comment.
moved to base type to share with VB.
CyrusNajmabadi
commented
Dec 5, 2024
| <[UseExportProvider]> | ||
| <Trait(Traits.Feature, Traits.Features.DebuggingDataTips)> | ||
| Public Class DataTipInfoGetterTests | ||
|
|
||
| Private Shared Async Function TestNoDataTipAsync(input As XElement) As Task |
There was a problem hiding this comment.
removed and replaced with calls to shared base class methods.
dibarbet
reviewed
Dec 5, 2024
| var document = context.GetRequiredDocument(); | ||
|
|
||
| var service = document.GetLanguageService<ILanguageDebugInfoService>(); | ||
| if (service is null) |
There was a problem hiding this comment.
Can this ever be null? I think I saw a C#/VB/F# implementation
There was a problem hiding this comment.
i wasn't certain what our rules were with LSP. like how xaml works there. i wwanted to be a little safe.
There was a problem hiding this comment.
this is exported as ExportCSharpVisualBasicStatelessLspService, so it applies only to the main roslyn server (which supports C#,VB, and F#). It won't be called for anything else
src/LanguageServer/Protocol/Protocol/Internal/VSInternalServerCapabilities.cs
Outdated
Show resolved
Hide resolved
src/LanguageServer/Protocol/Protocol/Internal/VSInternalDataTips.cs
Outdated
Show resolved
Hide resolved
src/LanguageServer/ProtocolUnitTests/DataTips/DataTipRangeHandlerTests.cs
Outdated
Show resolved
Hide resolved
src/LanguageServer/ProtocolUnitTests/DataTips/DataTipRangeHandlerTests.cs
Show resolved
Hide resolved
dibarbet
approved these changes
Dec 5, 2024
| } | ||
|
|
||
| internal readonly record struct DebugDataTipInfo( | ||
| TextSpan Span, TextSpan ExpressionSpan, string? Text, DebugDataTipInfoKind Kind = DebugDataTipInfoKind.None) |
There was a problem hiding this comment.
Yes. That should be the semantics of 'span'.
This was referenced Dec 12, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.