Remove scope variance exceptions #76296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Compilers
untriaged
jjonescz
force-pushed
the
76100-ScopeVariance-NoExceptions
branch
from
493ac3a to
f0d3f46
Compare
jjonescz
commented
Dec 9, 2024
| @@ -118,3 +118,22 @@ class C | |||
| } | |||
| ``` | |||
|
|
|||
| ## Variance of `scoped` and `[UnscopedRef]` is more strict | |||
There was a problem hiding this comment.
Note: I found these breaks when building the BCL with this change: dotnet/runtime@fae33d2e25a
jaredpar
reviewed
Dec 9, 2024
jaredpar
removed
the
untriaged
jaredpar
approved these changes
Dec 10, 2024
333fred
approved these changes
Dec 10, 2024
jjonescz
commented
Dec 12, 2024
| // We have removed exceptions to the scoped mismatch error reporting, but to avoid breaks | ||
| // we report the new scenarios (previously exempted) as warnings in C# 12 and earlier. | ||
| // https://github.com/dotnet/roslyn/issues/76100 | ||
| (overrideMethod.DeclaringCompilation.LanguageVersion > LanguageVersion.CSharp12 || usedToBeReported(baseMethod)); |
There was a problem hiding this comment.
Downgraded the new errors to warnings in C# 12 and lower to lessen the break per offline discussion with Jared. (We think breaking in C# 13 is fine since it's new.)
jaredpar
approved these changes
Dec 12, 2024
|
@cston @dotnet/roslyn-compiler for a second review, thanks |
333fred
approved these changes
Dec 19, 2024
71 tasks
jjonescz
added a commit
to jjonescz/roslyn
that referenced
this pull request
Jan 7, 2025
This reverts commit b86d831.
jjonescz
added a commit
to jjonescz/roslyn
that referenced
this pull request
Jan 7, 2025
This reverts commit b86d831.
This was referenced Jan 9, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #76100.
Alternative to #76261.
Speclet update: dotnet/csharplang#8777