Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Generate delegating constructor should make the implicit no-arg constructor explicit to preserve binary and source compat #76330

Merged
merged 2 commits into from
Dec 9, 2024
Merged

Generate delegating constructor should make the implicit no-arg constructor explicit to preserve binary and source compat #76330

merged 2 commits into from
Dec 9, 2024

Conversation

CyrusNajmabadi
Copy link
Member

Fixes #51049

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner December 7, 2024 23:29
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Dec 7, 2024
@CyrusNajmabadi
Copy link
Member Author

@JoeRobich @ToddGrun ptal

ToddGrun
ToddGrun approved these changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@ToddGrun ToddGrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@CyrusNajmabadi CyrusNajmabadi merged commit f8bc4f5 into dotnet:main Dec 9, 2024
25 checks passed
@CyrusNajmabadi CyrusNajmabadi deleted the genConstructorBinaryCompat branch December 9, 2024 20:40
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Dec 9, 2024
This was referenced Dec 12, 2024
Closed
Closed
Closed
@dibarbet dibarbet modified the milestones: Next, 17.13 P3 Jan 7, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ToddGrun ToddGrun ToddGrun approved these changes

@JoeRobich JoeRobich Awaiting requested review from JoeRobich

Assignees
No one assigned
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead VSCode
Projects
None yet
Milestone
17.13 P3
Development

Successfully merging this pull request may close these issues.

Generate constructor with parameter disables implicit constructor
3 participants
@CyrusNajmabadi @ToddGrun @dibarbet