Reduce allocations in CompletionItem.GetEntireDisplayText #76373
+8
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method's call to string.Concat shows up as about 0.4% of allocations during the typing scenario in the csharp editing speedometer test. Manual local testing was showing over 90% of calls to this method are done with both prefix and suffix strings empty. Unfortunately, netfx's string.Concat implementation still allocates in this case. Instead, we'll check for this case, and either do the string.Concat if necessary or just use DisplayText directly.
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
Wat |
CyrusNajmabadi
approved these changes
Dec 11, 2024
This was referenced Dec 13, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method's call to string.Concat shows up as about 0.4% of allocations during the typing scenario in the csharp editing speedometer test.
Manual local testing was showing over 90% of calls to this method are done with both prefix and suffix strings empty. Unfortunately, netfx's string.Concat implementation still allocates in this case. Instead, we'll check for this case, and either do the string.Concat if necessary or just use DisplayText directly.
*** allocations of interest from the csharp editing speedometer test ***
