Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Expose breakable range handler to Razor #76629

Merged
merged 2 commits into from
Jan 6, 2025

Conversation

davidwengier
Copy link
Member

Roslyn side of dotnet/razor#11337

@davidwengier davidwengier requested a review from dibarbet January 6, 2025 06:18
@davidwengier davidwengier requested a review from a team as a code owner January 6, 2025 06:18
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Jan 6, 2025
@davidwengier davidwengier merged commit 83debc8 into dotnet:main Jan 6, 2025
25 checks passed
@davidwengier davidwengier deleted the CohostingBreakpointRange branch January 6, 2025 20:50
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Jan 6, 2025
@dibarbet dibarbet modified the milestones: Next, 17.13 P3 Jan 7, 2025
davidwengier added a commit to dotnet/razor that referenced this pull request Jan 9, 2025
Fixes #11337
Needs dotnet/roslyn#76629

Ports one endpoint to cohosting
Updates two `IVsLanguageInfo` entry points to call cohosting in OOP
rather than making LSP calls.

These mostly just call Roslyn and don't do anything interesting with the
results. I thought about making some changes here (eg, does `__o` need
to be a proximity expression?) but given the very low test coverage of
our existing code, I didn't want to rock the boat.
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead VSCode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants