Fixing where ClearContained is called for certain Arm64 cast ops

dotnet · Oct 2, 2022 · 6e147d3 · 6e147d3
1 parent 144a33a
commit 6e147d3
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 7 deletions.
diff --git a/src/coreclr/jit/lower.cpp b/src/coreclr/jit/lower.cpp
@@ -2816,23 +2816,22 @@ GenTree* Lowering::OptimizeConstCompare(GenTree* cmp)
                 op2->gtType    = castToType;
 #endif
                 // If we have any contained memory ops on castOp, they must now not be contained.
+                castOp->ClearContained();
+
                 if (castOp->OperIs(GT_OR, GT_XOR, GT_AND))
                 {
                     GenTree* op1 = castOp->gtGetOp1();
                     if ((op1 != nullptr) && !op1->IsCnsIntOrI())
                     {
                         op1->ClearContained();
                     }
+
                     GenTree* op2 = castOp->gtGetOp2();
                     if ((op2 != nullptr) && !op2->IsCnsIntOrI())
                     {
                         op2->ClearContained();
                     }
                 }
-                else
-                {
-                    castOp->ClearContained();
-                }
 
                 cmp->AsOp()->gtOp1 = castOp;
 

diff --git a/src/coreclr/jit/lowerarmarch.cpp b/src/coreclr/jit/lowerarmarch.cpp
@@ -288,9 +288,6 @@ bool Lowering::IsContainableBinaryOp(GenTree* parentNode, GenTree* childNode) co
         // Find "a op cast(b)"
         GenTree* castOp = childNode->AsCast()->CastOp();
 
-        // We want to prefer the combined op here over containment of the cast op
-        castOp->ClearContained();
-
         bool isSupportedCast = false;
 
         if (varTypeIsSmall(childNode->CastToType()))
@@ -2010,13 +2007,25 @@ void Lowering::ContainCheckBinary(GenTreeOp* node)
     {
         if (IsContainableBinaryOp(node, op2))
         {
+            if (op2->OperIs(GT_CAST))
+            {
+                // We want to prefer the combined op here over containment of the cast op
+                op2->AsCast()->CastOp()->ClearContained();
+            }
             MakeSrcContained(node, op2);
+
             return;
         }
 
         if (node->OperIsCommutative() && IsContainableBinaryOp(node, op1))
         {
+            if (op1->OperIs(GT_CAST))
+            {
+                // We want to prefer the combined op here over containment of the cast op
+                op1->AsCast()->CastOp()->ClearContained();
+            }
             MakeSrcContained(node, op1);
+
             std::swap(node->gtOp1, node->gtOp2);
             return;
         }