Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

STJ NullPropertyNameFail test failing in CI #103715

Closed
stephentoub opened this issue Jun 19, 2024 · 3 comments
Closed

STJ NullPropertyNameFail test failing in CI #103715

stephentoub opened this issue Jun 19, 2024 · 3 comments
Assignees
@eiriktsarpalis
Labels
area-System.Text.Json blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' Known Build Error Use this to report build issues in the .NET Helix tab

Comments

@stephentoub
Copy link
Member

stephentoub commented Jun 19, 2024 •
edited by build-analysis bot
Loading

Build Information

Build: https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_build/results?buildId=712924
Build error leg or test failing: System.Text.Json.Nodes.Tests.JsonObjectTests.NullPropertyNameFail
Pull request: #103700

Error Message

Fill the error message using step by step known issues guidance.

{
  "ErrorMessage": "NullPropertyNameFail",
  "ErrorPattern": "",
  "BuildRetry": false,
  "ExcludeConsoleLog": false
}
Failing Configurations (2)
[net48-windows-Release-x86-NET48_Release-Windows.10.Amd64.Client.Open](https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_build/results?buildId=712924&view=ms.vss-test-web.build-test-results-tab&runId=17827020&resultId=131712)
[Ubuntu.2204.Amd64](https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_build/results?buildId=712924&view=ms.vss-test-web.build-test-results-tab&runId=17828326&resultId=172002)
Exception Message
Assert.Contains() Failure: Sub-string not found
String:    "System.ArgumentNullException: Value canno"···
Not found: "propertyName"

Known issue validation

Build: 🔎 https://dev.azure.com/dnceng-public/public/_build/results?buildId=712924
Error message validated: [NullPropertyNameFail]
Result validation: ✅ Known issue matched with the provided build.
Validation performed at: 6/19/2024 5:34:54 PM UTC

Report

Build Definition Test Pull Request
714215 dotnet/runtime WasmTestOnV8-ST-System.Text.Json.Tests.WorkItemExecution #103555
714201 dotnet/runtime WasmTestOnV8-ST-System.Text.Json.Tests.WorkItemExecution #103764
714185 dotnet/runtime WasmTestOnV8-ST-System.Text.Json.Tests.WorkItemExecution #103742
714171 dotnet/runtime WasmTestOnV8-ST-System.Text.Json.Tests.WorkItemExecution #103752
714143 dotnet/runtime System.Text.Json.Nodes.Tests.JsonObjectTests.NullPropertyNameFail #100334
713739 dotnet/runtime WasmTestOnV8-ST-System.Text.Json.Tests.WorkItemExecution #103646
713121 dotnet/runtime WasmTestOnV8-ST-System.Text.Json.Tests.WorkItemExecution #103710
714061 dotnet/runtime WasmTestOnV8-ST-System.Text.Json.Tests.WorkItemExecution #103635
714339 dotnet/runtime System.Text.Json.Nodes.Tests.JsonObjectTests.NullPropertyNameFail #103769
714331 dotnet/runtime System.Text.Json.Nodes.Tests.JsonObjectTests.NullPropertyNameFail #103706
714321 dotnet/runtime System.Text.Json.Nodes.Tests.JsonObjectTests.NullPropertyNameFail #103444
714312 dotnet/runtime System.Text.Json.Nodes.Tests.JsonObjectTests.NullPropertyNameFail #103639
714044 dotnet/runtime WasmTestOnV8-ST-System.Text.Json.Tests.WorkItemExecution #103759
714040 dotnet/runtime WasmTestOnV8-ST-System.Text.Json.Tests.WorkItemExecution #103697
714033 dotnet/runtime WasmTestOnV8-ST-System.Text.Json.Tests.WorkItemExecution #103758
714025 dotnet/runtime WasmTestOnV8-ST-System.Text.Json.Tests.WorkItemExecution #103757
714256 dotnet/runtime System.Text.Json.Nodes.Tests.JsonObjectTests.NullPropertyNameFail #103228
714245 dotnet/runtime System.Text.Json.Nodes.Tests.JsonObjectTests.NullPropertyNameFail #103705
714236 dotnet/runtime System.Text.Json.Nodes.Tests.JsonObjectTests.NullPropertyNameFail #103574
714225 dotnet/runtime System.Text.Json.Nodes.Tests.JsonObjectTests.NullPropertyNameFail #103765
714003 dotnet/runtime WasmTestOnV8-ST-System.Text.Json.Tests.WorkItemExecution #103412
713974 dotnet/runtime WasmTestOnV8-ST-System.Text.Json.Tests.WorkItemExecution #102739
713832 dotnet/runtime WasmTestOnV8-ST-System.Text.Json.Tests.WorkItemExecution #103748
713808 dotnet/runtime WasmTestOnV8-ST-System.Text.Json.Tests.WorkItemExecution
713796 dotnet/runtime WasmTestOnV8-ST-System.Text.Json.Tests.WorkItemExecution #103706
713768 dotnet/runtime WasmTestOnV8-ST-System.Text.Json.Tests.WorkItemExecution #103681
713716 dotnet/runtime WasmTestOnV8-ST-System.Text.Json.Tests.WorkItemExecution #103744
713704 dotnet/runtime WasmTestOnV8-ST-System.Text.Json.Tests.WorkItemExecution #103742
713697 dotnet/runtime System.Text.Json.Nodes.Tests.JsonObjectTests.NullPropertyNameFail #102739
713687 dotnet/runtime WasmTestOnV8-ST-System.Text.Json.Tests.WorkItemExecution #103728
713680 dotnet/runtime WasmTestOnV8-ST-System.Text.Json.Tests.WorkItemExecution #102403
713651 dotnet/runtime WasmTestOnV8-ST-System.Text.Json.Tests.WorkItemExecution #103740
713626 dotnet/runtime WasmTestOnV8-ST-System.Text.Json.Tests.WorkItemExecution #103739
713594 dotnet/runtime WasmTestOnV8-ST-System.Text.Json.Tests.WorkItemExecution #103737
713590 dotnet/runtime WasmTestOnV8-ST-System.Text.Json.Tests.WorkItemExecution #103617
713583 dotnet/runtime WasmTestOnV8-ST-System.Text.Json.Tests.WorkItemExecution #103607
713572 dotnet/runtime WasmTestOnV8-ST-System.Text.Json.Tests.WorkItemExecution #103184
713565 dotnet/runtime WasmTestOnV8-ST-System.Text.Json.Tests.WorkItemExecution #103728
713560 dotnet/runtime WasmTestOnV8-ST-System.Text.Json.Tests.WorkItemExecution #103663
713553 dotnet/runtime WasmTestOnV8-ST-System.Text.Json.Tests.WorkItemExecution #103673
713456 dotnet/runtime WasmTestOnV8-ST-System.Text.Json.Tests.WorkItemExecution #103104
713473 dotnet/runtime WasmTestOnV8-ST-System.Text.Json.Tests.WorkItemExecution #102655
713449 dotnet/runtime WasmTestOnV8-ST-System.Text.Json.Tests.WorkItemExecution #103729
713414 dotnet/runtime WasmTestOnV8-ST-System.Text.Json.Tests.WorkItemExecution #103555
713368 dotnet/runtime WasmTestOnV8-ST-System.Text.Json.Tests.WorkItemExecution #103725
713359 dotnet/runtime WasmTestOnV8-ST-System.Text.Json.Tests.WorkItemExecution
713329 dotnet/runtime WasmTestOnV8-ST-System.Text.Json.Tests.WorkItemExecution #103704
713295 dotnet/runtime System.Text.Json.Nodes.Tests.JsonObjectTests.NullPropertyNameFail #103721
713266 dotnet/runtime System.Text.Json.Nodes.Tests.JsonObjectTests.NullPropertyNameFail #103720
713206 dotnet/runtime WasmTestOnV8-ST-System.Text.Json.Tests.WorkItemExecution #103717
713168 dotnet/runtime System.Text.Json.Nodes.Tests.JsonObjectTests.NullPropertyNameFail #100334
713150 dotnet/runtime WasmTestOnV8-ST-System.Text.Json.Tests.WorkItemExecution #103444
713146 dotnet/runtime WasmTestOnV8-ST-System.Text.Json.Tests.WorkItemExecution #103714
713137 dotnet/runtime WasmTestOnV8-ST-System.Text.Json.Tests.WorkItemExecution #103713
713111 dotnet/runtime WasmTestOnV8-ST-System.Text.Json.Tests.WorkItemExecution #103673
712909 dotnet/runtime WasmTestOnV8-ST-System.Text.Json.Tests.WorkItemExecution #101531
713091 dotnet/runtime WasmTestOnV8-ST-System.Text.Json.Tests.WorkItemExecution #103555
713080 dotnet/runtime WasmTestOnV8-ST-System.Text.Json.Tests.WorkItemExecution #103337
713254 dotnet/runtime System.Text.Json.Nodes.Tests.JsonObjectTests.NullPropertyNameFail #103617
713243 dotnet/runtime System.Text.Json.Nodes.Tests.JsonObjectTests.NullPropertyNameFail #102403
713049 dotnet/runtime WasmTestOnV8-ST-System.Text.Json.Tests.WorkItemExecution #103689
713038 dotnet/runtime WasmTestOnV8-ST-System.Text.Json.Tests.WorkItemExecution #103706
713175 dotnet/runtime System.Text.Json.Nodes.Tests.JsonObjectTests.NullPropertyNameFail #103351
713026 dotnet/runtime WasmTestOnV8-ST-System.Text.Json.Tests.WorkItemExecution #103705
713158 dotnet/runtime System.Text.Json.Nodes.Tests.JsonObjectTests.NullPropertyNameFail #103681
713005 dotnet/runtime WasmTestOnV8-ST-System.Text.Json.Tests.WorkItemExecution #102739
713124 dotnet/runtime System.Text.Json.Nodes.Tests.JsonObjectTests.NullPropertyNameFail #103184
712969 dotnet/runtime WasmTestOnV8-ST-System.Text.Json.Tests.WorkItemExecution #103704
712924 dotnet/runtime WasmTestOnV8-ST-System.Text.Json.Tests.WorkItemExecution #103700
712737 dotnet/runtime WasmTestOnV8-ST-System.Text.Json.Tests.WorkItemExecution #103634
712718 dotnet/runtime WasmTestOnV8-ST-System.Text.Json.Tests.WorkItemExecution #103412
712690 dotnet/runtime WasmTestOnV8-ST-System.Text.Json.Tests.WorkItemExecution #103639

Summary

24-Hour Hit Count 7-Day Hit Count 1-Month Count
57 72 72
@stephentoub stephentoub added blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' Known Build Error Use this to report build issues in the .NET Helix tab labels Jun 19, 2024
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jun 19, 2024
@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label Jun 19, 2024
@stephentoub stephentoub added area-System.Text.Json and removed blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' untriaged New issue has not been triaged by the area owner Known Build Error Use this to report build issues in the .NET Helix tab needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Jun 19, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

@stephentoub stephentoub added blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' untriaged New issue has not been triaged by the area owner Known Build Error Use this to report build issues in the .NET Helix tab labels Jun 19, 2024
@lewing lewing mentioned this issue Jun 19, 2024
Merged
@lewing
Copy link
Member

lewing commented Jun 19, 2024 •
edited
Loading

This is failing outside of the wasm tests too but for some reason build analysis is only adding the wasm failures to the list above

https://helixre107v0xdcypoyl9e7f.blob.core.windows.net/dotnet-runtime-refs-pull-103700-merge-6de7c43e215a450881/System.Text.Json.Tests/1/console.3e62731e.log?helixlogtype=result

from https://github.com/dotnet/runtime/runs/26433093074

@eiriktsarpalis
Copy link
Member

This is presumably caused by #103645 which replaced the bespoke ordered dictionary with the new System.Collections.Generic.OrderedDictionary. I'm puzzled why this hasn't been failing on my local machine though.

eiriktsarpalis added a commit to eiriktsarpalis/runtime that referenced this issue Jun 19, 2024
@eiriktsarpalis
Fix dotnet#103715.
91c9d3c
@eiriktsarpalis eiriktsarpalis mentioned this issue Jun 20, 2024
Merged
@eiriktsarpalis eiriktsarpalis self-assigned this Jun 20, 2024
@dotnet-policy-service dotnet-policy-service bot removed the untriaged New issue has not been triaged by the area owner label Jun 20, 2024
@eiriktsarpalis eiriktsarpalis mentioned this issue Jun 20, 2024
Closed
rzikm pushed a commit to rzikm/dotnet-runtime that referenced this issue Jun 24, 2024
@eiriktsarpalis @rzikm
Performance improvements in JsonValue. (dotnet#103733)
7c6859e 
* Performance improvements in JsonValue.

* Fix dotnet#103715.

* Add more test cases and fix a number of bugs related to DeepEquals and escaping.

* Fix number handling corner case.
@github-actions github-actions bot locked and limited conversation to collaborators Jul 21, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees

@eiriktsarpalis eiriktsarpalis

Labels
area-System.Text.Json blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' Known Build Error Use this to report build issues in the .NET Helix tab
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lewing @stephentoub @eiriktsarpalis