Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Test build failure: "coreclr Common Pri1 Test Build AnyOS AnyCPU checked" CI job fails #108076

Closed
BruceForstall opened this issue Sep 20, 2024 · 6 comments · Fixed by #108077
Closed

Test build failure: "coreclr Common Pri1 Test Build AnyOS AnyCPU checked" CI job fails #108076

BruceForstall opened this issue Sep 20, 2024 · 6 comments · Fixed by #108077
Labels
area-Infrastructure-coreclr blocking-clean-ci-optional Blocking optional rolling runs blocking-outerloop Blocking the 'runtime-coreclr outerloop' and 'runtime-libraries-coreclr outerloop' runs in-pr There is an active PR which will close this issue when it is merged

Comments

@BruceForstall
Copy link
Member

Apparently starting with https://dev.azure.com/dnceng-public/public/_build/results?buildId=813293&view=results

    GCSimulator_127 -> /__w/1/s/artifacts/tests/coreclr/AnyOS.x64.Checked/GC/Scenarios/GCSimulator/GCSimulator_127/GCSimulator_127.dll
/__w/1/s/artifacts/tests/coreclr/obj/AnyOS.x64.Checked/Managed/CoreMangLib/CoreMangLib/generated/XUnitWrapperGenerator/XUnitWrapperGenerator.XUnitWrapperGenerator/FullRunner.g.cs(618,61): error CS0012: The type 'Object' is defined in an assembly that is not referenced. You must add a reference to assembly 'System.Runtime, Version=0.0.0.0, Culture=neutral, PublicKeyToken=null'. [/__w/1/s/src/tests/CoreMangLib/CoreMangLib.csproj] [/__w/1/s/src/tests/build.proj]
##[error]artifacts/tests/coreclr/obj/AnyOS.x64.Checked/Managed/CoreMangLib/CoreMangLib/generated/XUnitWrapperGenerator/XUnitWrapperGenerator.XUnitWrapperGenerator/FullRunner.g.cs(618,61): error CS0012: The type 'Object' is defined in an assembly that is not referenced. You must add a reference to assembly 'System.Runtime, Version=0.0.0.0, Culture=neutral, PublicKeyToken=null'. [/__w/1/s/src/tests/CoreMangLib/CoreMangLib.csproj]
    GCSimulator_129 -> /__w/1/s/artifacts/tests/coreclr/AnyOS.x64.Checked/GC/Scenarios/GCSimulator/GCSimulator_129/GCSimulator_129.dll

Maybe due to #104731? @jkotas @huoyaoyuan
@BruceForstall BruceForstall added blocking-clean-ci-optional Blocking optional rolling runs blocking-outerloop Blocking the 'runtime-coreclr outerloop' and 'runtime-libraries-coreclr outerloop' runs labels Sep 20, 2024
@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label Sep 20, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

@BruceForstall
Copy link
Member Author

Fails in runtime-coreclr outerloop, but also in every outerloop pipeline that needs Pri-1 coreclr tests

jkotas added a commit to jkotas/runtime that referenced this issue Sep 20, 2024
@jkotas
Testing
f60334a 
Re dotnet#108076
@jkotas jkotas mentioned this issue Sep 20, 2024
Merged
@BruceForstall
Copy link
Member Author

@jkotas Did your test #108077 verify that the build failure was caused by #104731?

Looks like your "Fix?" there didn't work.

BruceForstall added a commit to BruceForstall/runtime that referenced this issue Sep 21, 2024
@BruceForstall
Disable InvokeNull test, which is breaking the build
726533a 
Tracking: dotnet#108076
@BruceForstall BruceForstall mentioned this issue Sep 21, 2024
Closed
@BruceForstall
Copy link
Member Author

A possible "big hammer" fix (that is not a full revert): #108093

jkotas added a commit to jkotas/runtime that referenced this issue Sep 21, 2024
@jkotas
Fix System.Runtime reference in a new test
c6bb7f9 
Fixes #dotnet#108076
@jkotas
Copy link
Member

jkotas commented Sep 21, 2024

@jkotas Did your test #108077 verify that the build failure was caused by #104731?

Yes, it was caused by #104731. I have pushed a new change that should fix the build break (verified locally).

@dotnet-policy-service dotnet-policy-service bot added the in-pr There is an active PR which will close this issue when it is merged label Sep 21, 2024
@huoyaoyuan
Copy link
Member

I copied the pattern from some other test and it was successful when I tested it locally. I don't recall much details, but I had some issues building tests and did some workaround.

jkotas added a commit that referenced this issue Sep 21, 2024
@jkotas
Fix System.Runtime reference in a new test (#108077)
0ead293 
Fixes ##108076
@dotnet-policy-service dotnet-policy-service bot removed the untriaged New issue has not been triaged by the area owner label Sep 21, 2024
sirntar pushed a commit to sirntar/runtime that referenced this issue Sep 30, 2024
@jkotas @sirntar
Fix System.Runtime reference in a new test (dotnet#108077)
9f76c73 
Fixes #dotnet#108076
@github-actions github-actions bot locked and limited conversation to collaborators Oct 22, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees
No one assigned
Labels
area-Infrastructure-coreclr blocking-clean-ci-optional Blocking optional rolling runs blocking-outerloop Blocking the 'runtime-coreclr outerloop' and 'runtime-libraries-coreclr outerloop' runs in-pr There is an active PR which will close this issue when it is merged
Projects
Runtime Infra
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix System.Runtime reference in a new test jkotas/runtime
3 participants
@huoyaoyuan @jkotas @BruceForstall