Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[trimming] System.Diagnostics trimming out DebuggerTypeProxyAttribute. #57588

Open
lewing opened this issue Aug 17, 2021 · 16 comments
Open

[trimming] System.Diagnostics trimming out DebuggerTypeProxyAttribute. #57588

lewing opened this issue Aug 17, 2021 · 16 comments
Assignees
@thaystg
Labels
arch-wasm WebAssembly architecture area-System.Collections disabled-test The test is disabled in source code against the issue os-ios Apple iOS test-failure trimming-for-aot `EnableAggressiveTrimming=true` used for running tests with AOT
Milestone
Future

Comments

@lewing
Copy link
Member

lewing commented Aug 17, 2021 

[01:53:09] fail: [FAIL] System.Collections.ObjectModel.Tests.ReadOnlyDictionaryTests.DebuggerAttribute_NullDictionary_ThrowsArgumentNullException
[01:53:09] info: Assert.Throws() Failure
[01:53:09] info: Expected: typeof(System.Reflection.TargetInvocationException)
[01:53:09] info: Actual:   typeof(System.InvalidOperationException): Expected one DebuggerTypeProxyAttribute on System.Collections.ObjectModel.ReadOnlyDictionary`2[System.Int32,System.Int32].
[01:53:09] info: ---- System.InvalidOperationException : Expected one DebuggerTypeProxyAttribute on System.Collections.ObjectModel.ReadOnlyDictionary`2[System.Int32,System.Int32].
[01:53:09] info:    at System.Diagnostics.DebuggerAttributes.GetProxyType(Type type, Type[] genericTypeArguments)
[01:53:09] info:    at System.Diagnostics.DebuggerAttributes.ValidateDebuggerTypeProxyProperties(Type type, Type[] genericTypeArguments, Object obj)
[01:53:09] info:    at System.Diagnostics.DebuggerAttributes.ValidateDebuggerTypeProxyProperties(Type type, Object obj)
[01:53:09] info:    at System.Collections.ObjectModel.Tests.ReadOnlyDictionaryTests.<>c.<DebuggerAttribute_NullDictionary_ThrowsArgumentNullException>b__13_0()
[01:53:09] info: ----- Inner Stack Trace -----
[01:53:09] info:    at System.Diagnostics.DebuggerAttributes.GetProxyType(Type type, Type[] genericTypeArguments)
[01:53:09] info:    at System.Diagnostics.DebuggerAttributes.ValidateDebuggerTypeProxyProperties(Type type, Type[] genericTypeArguments, Object obj)
[01:53:09] info:    at System.Diagnostics.DebuggerAttributes.ValidateDebuggerTypeProxyProperties(Type type, Object obj)
[01:53:09] info:    at System.Collections.ObjectModel.Tests.ReadOnlyDictionaryTests.<>c.<DebuggerAttribute_NullDictionary_ThrowsArgumentNullException>b__13_0()
[01:53:09] fail: [FAIL] System.Collections.ObjectModel.Tests.ReadOnlyDictionaryTests.DebuggerAttribute_NullDictionaryKeys_ThrowsArgumentNullException
[01:53:09] info: Assert.Throws() Failure
[01:53:09] info: Expected: typeof(System.Reflection.TargetInvocationException)
[01:53:09] info: Actual:   typeof(System.InvalidOperationException): Expected one DebuggerTypeProxyAttribute on System.Collections.ObjectModel.ReadOnlyDictionary`2+KeyCollection[System.Int32,System.Int32].
[01:53:09] info: ---- System.InvalidOperationException : Expected one DebuggerTypeProxyAttribute on System.Collections.ObjectModel.ReadOnlyDictionary`2+KeyCollection[System.Int32,System.Int32].
[01:53:09] info:    at System.Diagnostics.DebuggerAttributes.GetProxyType(Type type, Type[] genericTypeArguments)
[01:53:09] info:    at System.Diagnostics.DebuggerAttributes.ValidateDebuggerTypeProxyProperties(Type type, Type[] genericTypeArguments, Object obj)
[01:53:09] info:    at System.Collections.ObjectModel.Tests.ReadOnlyDictionaryTests.<>c.<DebuggerAttribute_NullDictionaryKeys_ThrowsArgumentNullException>b__14_0()
[01:53:09] info: ----- Inner Stack Trace -----
[01:53:09] info:    at System.Diagnostics.DebuggerAttributes.GetProxyType(Type type, Type[] genericTypeArguments)
[01:53:09] info:    at System.Diagnostics.DebuggerAttributes.ValidateDebuggerTypeProxyProperties(Type type, Type[] genericTypeArguments, Object obj)
[01:53:09] info:    at System.Collections.ObjectModel.Tests.ReadOnlyDictionaryTests.<>c.<DebuggerAttribute_NullDictionaryKeys_ThrowsArgumentNullException>b__14_0()
[01:53:09] fail: [FAIL] System.Collections.ObjectModel.Tests.ReadOnlyDictionaryTests.DebuggerAttributeTests
[01:53:09] info: System.InvalidOperationException : Expected one DebuggerDisplayAttribute on System.Collections.ObjectModel.ReadOnlyDictionary`2[System.Int32,System.Int32].
[01:53:09] info:    at System.Diagnostics.DebuggerAttributes.ValidateDebuggerDisplayReferences(Object obj)
[01:53:09] info:    at System.Collections.ObjectModel.Tests.ReadOnlyDictionaryTests.DebuggerAttributeTests()
[01:53:09] info:    at System.Reflection.RuntimeMethodInfo.Invoke(Object , BindingFlags , Binder , Object[] , CultureInfo )
[01:53:09] fail: [FAIL] System.Collections.ObjectModel.Tests.ConstructorAndPropertyTests.DebuggerAttributeTests
[01:53:09] info: System.InvalidOperationException : Expected one DebuggerDisplayAttribute on System.Collections.ObjectModel.ObservableCollection`1[System.Int32].
[01:53:09] info:    at System.Diagnostics.DebuggerAttributes.ValidateDebuggerDisplayReferences(Object obj)
[01:53:09] info:    at System.Collections.ObjectModel.Tests.ConstructorAndPropertyTests.DebuggerAttributeTests()
[01:53:09] info:    at System.Reflection.RuntimeMethodInfo.Invoke(Object , BindingFlags , Binder , Object[] , CultureInfo )
[01:53:09] fail: [FAIL] System.Collections.ObjectModel.Tests.ConstructorAndPropertyTests.DebuggerAttribute_NullCollection_ThrowsArgumentNullException
[01:53:09] info: Assert.Throws() Failure
[01:53:09] info: Expected: typeof(System.Reflection.TargetInvocationException)
[01:53:09] info: Actual:   typeof(System.InvalidOperationException): Expected one DebuggerTypeProxyAttribute on System.Collections.ObjectModel.ObservableCollection`1[System.Int32].
[01:53:09] info: ---- System.InvalidOperationException : Expected one DebuggerTypeProxyAttribute on System.Collections.ObjectModel.ObservableCollection`1[System.Int32].
[01:53:09] info:    at System.Diagnostics.DebuggerAttributes.GetProxyType(Type type, Type[] genericTypeArguments)
[01:53:09] info:    at System.Diagnostics.DebuggerAttributes.ValidateDebuggerTypeProxyProperties(Type type, Type[] genericTypeArguments, Object obj)
[01:53:09] info:    at System.Diagnostics.DebuggerAttributes.ValidateDebuggerTypeProxyProperties(Type type, Object obj)
[01:53:09] info:    at System.Collections.ObjectModel.Tests.ConstructorAndPropertyTests.<>c.<DebuggerAttribute_NullCollection_ThrowsArgumentNullException>b__11_0()
[01:53:09] info: ----- Inner Stack Trace -----
[01:53:09] info:    at System.Diagnostics.DebuggerAttributes.GetProxyType(Type type, Type[] genericTypeArguments)
[01:53:09] info:    at System.Diagnostics.DebuggerAttributes.ValidateDebuggerTypeProxyProperties(Type type, Type[] genericTypeArguments, Object obj)
[01:53:09] info:    at System.Diagnostics.DebuggerAttributes.ValidateDebuggerTypeProxyProperties(Type type, Object obj)
[01:53:09] info:    at System.Collections.ObjectModel.Tests.ConstructorAndPropertyTests.<>c.<DebuggerAttribute_NullCollection_ThrowsArgumentNullException>b__11_0()
[01:53:20] fail: [FAIL] System.Collections.ObjectModel.Tests.ObservableCollection_Serialization.OnDeserialized_MonitorNotInitialized_ExpectSuccess
[01:53:20] info: Assert.NotNull() Failure
[01:53:20] info:    at System.Collections.ObjectModel.Tests.ObservableCollection_Serialization.OnDeserialized_MonitorNotInitialized_ExpectSuccess()
[01:53:20] info:    at System.Reflection.RuntimeMethodInfo.Invoke(Object , BindingFlags , Binder , Object[] , CultureInfo )
[01:53:21] fail: [FAIL] System.Collections.ObjectModel.Tests.ReadOnlyObservableCollectionTests.DebuggerAttribute_Tests
[01:53:21] info: System.InvalidOperationException : Expected one DebuggerDisplayAttribute on System.Collections.ObjectModel.ReadOnlyObservableCollection`1[System.Int32].
[01:53:21] info:    at System.Diagnostics.DebuggerAttributes.ValidateDebuggerDisplayReferences(Object obj)
[01:53:21] info:    at System.Collections.ObjectModel.Tests.ReadOnlyObservableCollectionTests.DebuggerAttribute_Tests()
[01:53:21] info:    at System.Reflection.RuntimeMethodInfo.Invoke(Object , BindingFlags , Binder , Object[] , CultureInfo )
[01:53:21] fail: [FAIL] System.Collections.ObjectModel.Tests.ReadOnlyObservableCollectionTests.DebuggerAttribute_NullCollection_ThrowsArgumentNullException
[01:53:21] info: Assert.Throws() Failure
[01:53:21] info: Expected: typeof(System.Reflection.TargetInvocationException)
[01:53:21] info: Actual:   typeof(System.InvalidOperationException): Expected one DebuggerTypeProxyAttribute on System.Collections.ObjectModel.ReadOnlyObservableCollection`1[System.Int32].
[01:53:21] info: ---- System.InvalidOperationException : Expected one DebuggerTypeProxyAttribute on System.Collections.ObjectModel.ReadOnlyObservableCollection`1[System.Int32].
[01:53:21] info:    at System.Diagnostics.DebuggerAttributes.GetProxyType(Type type, Type[] genericTypeArguments)
[01:53:21] info:    at System.Diagnostics.DebuggerAttributes.ValidateDebuggerTypeProxyProperties(Type type, Type[] genericTypeArguments, Object obj)
[01:53:21] info:    at System.Diagnostics.DebuggerAttributes.ValidateDebuggerTypeProxyProperties(Type type, Object obj)
[01:53:21] info:    at System.Collections.ObjectModel.Tests.ReadOnlyObservableCollectionTests.<>c.<DebuggerAttribute_NullCollection_ThrowsArgumentNullException>b__10_0()
[01:53:21] info: ----- Inner Stack Trace -----
[01:53:21] info:    at System.Diagnostics.DebuggerAttributes.GetProxyType(Type type, Type[] genericTypeArguments)
[01:53:21] info:    at System.Diagnostics.DebuggerAttributes.ValidateDebuggerTypeProxyProperties(Type type, Type[] genericTypeArguments, Object obj)
[01:53:21] info:    at System.Diagnostics.DebuggerAttributes.ValidateDebuggerTypeProxyProperties(Type type, Object obj)
[01:53:21] info:    at System.Collections.ObjectModel.Tests.ReadOnlyObservableCollectionTests.<>c.<DebuggerAttribute_NullCollection_ThrowsArgumentNullException>b__10_0()
[01:53:21] info: Finished:    System.ObjectModel.Tests.dll
[01:53:21] info: 
[01:53:21] info: === TEST EXECUTION SUMMARY ===
[01:53:21] info: Total: 2152, Errors: 0, Failed: 8, Skipped: 4, Time: 24.01992s
@lewing lewing added arch-wasm WebAssembly architecture trimming-for-aot `EnableAggressiveTrimming=true` used for running tests with AOT labels Aug 17, 2021
@lewing lewing added this to the 7.0.0 milestone Aug 17, 2021
@ghost
Copy link

ghost commented Aug 17, 2021

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details 
[01:53:09] fail: [FAIL] System.Collections.ObjectModel.Tests.ReadOnlyDictionaryTests.DebuggerAttribute_NullDictionary_ThrowsArgumentNullException
[01:53:09] info: Assert.Throws() Failure
[01:53:09] info: Expected: typeof(System.Reflection.TargetInvocationException)
[01:53:09] info: Actual:   typeof(System.InvalidOperationException): Expected one DebuggerTypeProxyAttribute on System.Collections.ObjectModel.ReadOnlyDictionary`2[System.Int32,System.Int32].
[01:53:09] info: ---- System.InvalidOperationException : Expected one DebuggerTypeProxyAttribute on System.Collections.ObjectModel.ReadOnlyDictionary`2[System.Int32,System.Int32].
[01:53:09] info:    at System.Diagnostics.DebuggerAttributes.GetProxyType(Type type, Type[] genericTypeArguments)
[01:53:09] info:    at System.Diagnostics.DebuggerAttributes.ValidateDebuggerTypeProxyProperties(Type type, Type[] genericTypeArguments, Object obj)
[01:53:09] info:    at System.Diagnostics.DebuggerAttributes.ValidateDebuggerTypeProxyProperties(Type type, Object obj)
[01:53:09] info:    at System.Collections.ObjectModel.Tests.ReadOnlyDictionaryTests.<>c.<DebuggerAttribute_NullDictionary_ThrowsArgumentNullException>b__13_0()
[01:53:09] info: ----- Inner Stack Trace -----
[01:53:09] info:    at System.Diagnostics.DebuggerAttributes.GetProxyType(Type type, Type[] genericTypeArguments)
[01:53:09] info:    at System.Diagnostics.DebuggerAttributes.ValidateDebuggerTypeProxyProperties(Type type, Type[] genericTypeArguments, Object obj)
[01:53:09] info:    at System.Diagnostics.DebuggerAttributes.ValidateDebuggerTypeProxyProperties(Type type, Object obj)
[01:53:09] info:    at System.Collections.ObjectModel.Tests.ReadOnlyDictionaryTests.<>c.<DebuggerAttribute_NullDictionary_ThrowsArgumentNullException>b__13_0()
[01:53:09] fail: [FAIL] System.Collections.ObjectModel.Tests.ReadOnlyDictionaryTests.DebuggerAttribute_NullDictionaryKeys_ThrowsArgumentNullException
[01:53:09] info: Assert.Throws() Failure
[01:53:09] info: Expected: typeof(System.Reflection.TargetInvocationException)
[01:53:09] info: Actual:   typeof(System.InvalidOperationException): Expected one DebuggerTypeProxyAttribute on System.Collections.ObjectModel.ReadOnlyDictionary`2+KeyCollection[System.Int32,System.Int32].
[01:53:09] info: ---- System.InvalidOperationException : Expected one DebuggerTypeProxyAttribute on System.Collections.ObjectModel.ReadOnlyDictionary`2+KeyCollection[System.Int32,System.Int32].
[01:53:09] info:    at System.Diagnostics.DebuggerAttributes.GetProxyType(Type type, Type[] genericTypeArguments)
[01:53:09] info:    at System.Diagnostics.DebuggerAttributes.ValidateDebuggerTypeProxyProperties(Type type, Type[] genericTypeArguments, Object obj)
[01:53:09] info:    at System.Collections.ObjectModel.Tests.ReadOnlyDictionaryTests.<>c.<DebuggerAttribute_NullDictionaryKeys_ThrowsArgumentNullException>b__14_0()
[01:53:09] info: ----- Inner Stack Trace -----
[01:53:09] info:    at System.Diagnostics.DebuggerAttributes.GetProxyType(Type type, Type[] genericTypeArguments)
[01:53:09] info:    at System.Diagnostics.DebuggerAttributes.ValidateDebuggerTypeProxyProperties(Type type, Type[] genericTypeArguments, Object obj)
[01:53:09] info:    at System.Collections.ObjectModel.Tests.ReadOnlyDictionaryTests.<>c.<DebuggerAttribute_NullDictionaryKeys_ThrowsArgumentNullException>b__14_0()
[01:53:09] fail: [FAIL] System.Collections.ObjectModel.Tests.ReadOnlyDictionaryTests.DebuggerAttributeTests
[01:53:09] info: System.InvalidOperationException : Expected one DebuggerDisplayAttribute on System.Collections.ObjectModel.ReadOnlyDictionary`2[System.Int32,System.Int32].
[01:53:09] info:    at System.Diagnostics.DebuggerAttributes.ValidateDebuggerDisplayReferences(Object obj)
[01:53:09] info:    at System.Collections.ObjectModel.Tests.ReadOnlyDictionaryTests.DebuggerAttributeTests()
[01:53:09] info:    at System.Reflection.RuntimeMethodInfo.Invoke(Object , BindingFlags , Binder , Object[] , CultureInfo )
[01:53:09] fail: [FAIL] System.Collections.ObjectModel.Tests.ConstructorAndPropertyTests.DebuggerAttributeTests
[01:53:09] info: System.InvalidOperationException : Expected one DebuggerDisplayAttribute on System.Collections.ObjectModel.ObservableCollection`1[System.Int32].
[01:53:09] info:    at System.Diagnostics.DebuggerAttributes.ValidateDebuggerDisplayReferences(Object obj)
[01:53:09] info:    at System.Collections.ObjectModel.Tests.ConstructorAndPropertyTests.DebuggerAttributeTests()
[01:53:09] info:    at System.Reflection.RuntimeMethodInfo.Invoke(Object , BindingFlags , Binder , Object[] , CultureInfo )
[01:53:09] fail: [FAIL] System.Collections.ObjectModel.Tests.ConstructorAndPropertyTests.DebuggerAttribute_NullCollection_ThrowsArgumentNullException
[01:53:09] info: Assert.Throws() Failure
[01:53:09] info: Expected: typeof(System.Reflection.TargetInvocationException)
[01:53:09] info: Actual:   typeof(System.InvalidOperationException): Expected one DebuggerTypeProxyAttribute on System.Collections.ObjectModel.ObservableCollection`1[System.Int32].
[01:53:09] info: ---- System.InvalidOperationException : Expected one DebuggerTypeProxyAttribute on System.Collections.ObjectModel.ObservableCollection`1[System.Int32].
[01:53:09] info:    at System.Diagnostics.DebuggerAttributes.GetProxyType(Type type, Type[] genericTypeArguments)
[01:53:09] info:    at System.Diagnostics.DebuggerAttributes.ValidateDebuggerTypeProxyProperties(Type type, Type[] genericTypeArguments, Object obj)
[01:53:09] info:    at System.Diagnostics.DebuggerAttributes.ValidateDebuggerTypeProxyProperties(Type type, Object obj)
[01:53:09] info:    at System.Collections.ObjectModel.Tests.ConstructorAndPropertyTests.<>c.<DebuggerAttribute_NullCollection_ThrowsArgumentNullException>b__11_0()
[01:53:09] info: ----- Inner Stack Trace -----
[01:53:09] info:    at System.Diagnostics.DebuggerAttributes.GetProxyType(Type type, Type[] genericTypeArguments)
[01:53:09] info:    at System.Diagnostics.DebuggerAttributes.ValidateDebuggerTypeProxyProperties(Type type, Type[] genericTypeArguments, Object obj)
[01:53:09] info:    at System.Diagnostics.DebuggerAttributes.ValidateDebuggerTypeProxyProperties(Type type, Object obj)
[01:53:09] info:    at System.Collections.ObjectModel.Tests.ConstructorAndPropertyTests.<>c.<DebuggerAttribute_NullCollection_ThrowsArgumentNullException>b__11_0()
[01:53:20] fail: [FAIL] System.Collections.ObjectModel.Tests.ObservableCollection_Serialization.OnDeserialized_MonitorNotInitialized_ExpectSuccess
[01:53:20] info: Assert.NotNull() Failure
[01:53:20] info:    at System.Collections.ObjectModel.Tests.ObservableCollection_Serialization.OnDeserialized_MonitorNotInitialized_ExpectSuccess()
[01:53:20] info:    at System.Reflection.RuntimeMethodInfo.Invoke(Object , BindingFlags , Binder , Object[] , CultureInfo )
[01:53:21] fail: [FAIL] System.Collections.ObjectModel.Tests.ReadOnlyObservableCollectionTests.DebuggerAttribute_Tests
[01:53:21] info: System.InvalidOperationException : Expected one DebuggerDisplayAttribute on System.Collections.ObjectModel.ReadOnlyObservableCollection`1[System.Int32].
[01:53:21] info:    at System.Diagnostics.DebuggerAttributes.ValidateDebuggerDisplayReferences(Object obj)
[01:53:21] info:    at System.Collections.ObjectModel.Tests.ReadOnlyObservableCollectionTests.DebuggerAttribute_Tests()
[01:53:21] info:    at System.Reflection.RuntimeMethodInfo.Invoke(Object , BindingFlags , Binder , Object[] , CultureInfo )
[01:53:21] fail: [FAIL] System.Collections.ObjectModel.Tests.ReadOnlyObservableCollectionTests.DebuggerAttribute_NullCollection_ThrowsArgumentNullException
[01:53:21] info: Assert.Throws() Failure
[01:53:21] info: Expected: typeof(System.Reflection.TargetInvocationException)
[01:53:21] info: Actual:   typeof(System.InvalidOperationException): Expected one DebuggerTypeProxyAttribute on System.Collections.ObjectModel.ReadOnlyObservableCollection`1[System.Int32].
[01:53:21] info: ---- System.InvalidOperationException : Expected one DebuggerTypeProxyAttribute on System.Collections.ObjectModel.ReadOnlyObservableCollection`1[System.Int32].
[01:53:21] info:    at System.Diagnostics.DebuggerAttributes.GetProxyType(Type type, Type[] genericTypeArguments)
[01:53:21] info:    at System.Diagnostics.DebuggerAttributes.ValidateDebuggerTypeProxyProperties(Type type, Type[] genericTypeArguments, Object obj)
[01:53:21] info:    at System.Diagnostics.DebuggerAttributes.ValidateDebuggerTypeProxyProperties(Type type, Object obj)
[01:53:21] info:    at System.Collections.ObjectModel.Tests.ReadOnlyObservableCollectionTests.<>c.<DebuggerAttribute_NullCollection_ThrowsArgumentNullException>b__10_0()
[01:53:21] info: ----- Inner Stack Trace -----
[01:53:21] info:    at System.Diagnostics.DebuggerAttributes.GetProxyType(Type type, Type[] genericTypeArguments)
[01:53:21] info:    at System.Diagnostics.DebuggerAttributes.ValidateDebuggerTypeProxyProperties(Type type, Type[] genericTypeArguments, Object obj)
[01:53:21] info:    at System.Diagnostics.DebuggerAttributes.ValidateDebuggerTypeProxyProperties(Type type, Object obj)
[01:53:21] info:    at System.Collections.ObjectModel.Tests.ReadOnlyObservableCollectionTests.<>c.<DebuggerAttribute_NullCollection_ThrowsArgumentNullException>b__10_0()
[01:53:21] info: Finished:    System.ObjectModel.Tests.dll
[01:53:21] info: 
[01:53:21] info: === TEST EXECUTION SUMMARY ===
[01:53:21] info: Total: 2152, Errors: 0, Failed: 8, Skipped: 4, Time: 24.01992s
Author: lewing
Assignees: -
Labels:

arch-wasm, trimming-for-aot
Milestone: 7.0.0

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Aug 17, 2021
@lewing lewing removed the untriaged New issue has not been triaged by the area owner label Aug 17, 2021
@ghost
Copy link

ghost commented Aug 18, 2021

Tagging subscribers to this area: @tommcdon, @krwq
See info in area-owners.md if you want to be subscribed.

Issue Details 
[01:53:09] fail: [FAIL] System.Collections.ObjectModel.Tests.ReadOnlyDictionaryTests.DebuggerAttribute_NullDictionary_ThrowsArgumentNullException
[01:53:09] info: Assert.Throws() Failure
[01:53:09] info: Expected: typeof(System.Reflection.TargetInvocationException)
[01:53:09] info: Actual:   typeof(System.InvalidOperationException): Expected one DebuggerTypeProxyAttribute on System.Collections.ObjectModel.ReadOnlyDictionary`2[System.Int32,System.Int32].
[01:53:09] info: ---- System.InvalidOperationException : Expected one DebuggerTypeProxyAttribute on System.Collections.ObjectModel.ReadOnlyDictionary`2[System.Int32,System.Int32].
[01:53:09] info:    at System.Diagnostics.DebuggerAttributes.GetProxyType(Type type, Type[] genericTypeArguments)
[01:53:09] info:    at System.Diagnostics.DebuggerAttributes.ValidateDebuggerTypeProxyProperties(Type type, Type[] genericTypeArguments, Object obj)
[01:53:09] info:    at System.Diagnostics.DebuggerAttributes.ValidateDebuggerTypeProxyProperties(Type type, Object obj)
[01:53:09] info:    at System.Collections.ObjectModel.Tests.ReadOnlyDictionaryTests.<>c.<DebuggerAttribute_NullDictionary_ThrowsArgumentNullException>b__13_0()
[01:53:09] info: ----- Inner Stack Trace -----
[01:53:09] info:    at System.Diagnostics.DebuggerAttributes.GetProxyType(Type type, Type[] genericTypeArguments)
[01:53:09] info:    at System.Diagnostics.DebuggerAttributes.ValidateDebuggerTypeProxyProperties(Type type, Type[] genericTypeArguments, Object obj)
[01:53:09] info:    at System.Diagnostics.DebuggerAttributes.ValidateDebuggerTypeProxyProperties(Type type, Object obj)
[01:53:09] info:    at System.Collections.ObjectModel.Tests.ReadOnlyDictionaryTests.<>c.<DebuggerAttribute_NullDictionary_ThrowsArgumentNullException>b__13_0()
[01:53:09] fail: [FAIL] System.Collections.ObjectModel.Tests.ReadOnlyDictionaryTests.DebuggerAttribute_NullDictionaryKeys_ThrowsArgumentNullException
[01:53:09] info: Assert.Throws() Failure
[01:53:09] info: Expected: typeof(System.Reflection.TargetInvocationException)
[01:53:09] info: Actual:   typeof(System.InvalidOperationException): Expected one DebuggerTypeProxyAttribute on System.Collections.ObjectModel.ReadOnlyDictionary`2+KeyCollection[System.Int32,System.Int32].
[01:53:09] info: ---- System.InvalidOperationException : Expected one DebuggerTypeProxyAttribute on System.Collections.ObjectModel.ReadOnlyDictionary`2+KeyCollection[System.Int32,System.Int32].
[01:53:09] info:    at System.Diagnostics.DebuggerAttributes.GetProxyType(Type type, Type[] genericTypeArguments)
[01:53:09] info:    at System.Diagnostics.DebuggerAttributes.ValidateDebuggerTypeProxyProperties(Type type, Type[] genericTypeArguments, Object obj)
[01:53:09] info:    at System.Collections.ObjectModel.Tests.ReadOnlyDictionaryTests.<>c.<DebuggerAttribute_NullDictionaryKeys_ThrowsArgumentNullException>b__14_0()
[01:53:09] info: ----- Inner Stack Trace -----
[01:53:09] info:    at System.Diagnostics.DebuggerAttributes.GetProxyType(Type type, Type[] genericTypeArguments)
[01:53:09] info:    at System.Diagnostics.DebuggerAttributes.ValidateDebuggerTypeProxyProperties(Type type, Type[] genericTypeArguments, Object obj)
[01:53:09] info:    at System.Collections.ObjectModel.Tests.ReadOnlyDictionaryTests.<>c.<DebuggerAttribute_NullDictionaryKeys_ThrowsArgumentNullException>b__14_0()
[01:53:09] fail: [FAIL] System.Collections.ObjectModel.Tests.ReadOnlyDictionaryTests.DebuggerAttributeTests
[01:53:09] info: System.InvalidOperationException : Expected one DebuggerDisplayAttribute on System.Collections.ObjectModel.ReadOnlyDictionary`2[System.Int32,System.Int32].
[01:53:09] info:    at System.Diagnostics.DebuggerAttributes.ValidateDebuggerDisplayReferences(Object obj)
[01:53:09] info:    at System.Collections.ObjectModel.Tests.ReadOnlyDictionaryTests.DebuggerAttributeTests()
[01:53:09] info:    at System.Reflection.RuntimeMethodInfo.Invoke(Object , BindingFlags , Binder , Object[] , CultureInfo )
[01:53:09] fail: [FAIL] System.Collections.ObjectModel.Tests.ConstructorAndPropertyTests.DebuggerAttributeTests
[01:53:09] info: System.InvalidOperationException : Expected one DebuggerDisplayAttribute on System.Collections.ObjectModel.ObservableCollection`1[System.Int32].
[01:53:09] info:    at System.Diagnostics.DebuggerAttributes.ValidateDebuggerDisplayReferences(Object obj)
[01:53:09] info:    at System.Collections.ObjectModel.Tests.ConstructorAndPropertyTests.DebuggerAttributeTests()
[01:53:09] info:    at System.Reflection.RuntimeMethodInfo.Invoke(Object , BindingFlags , Binder , Object[] , CultureInfo )
[01:53:09] fail: [FAIL] System.Collections.ObjectModel.Tests.ConstructorAndPropertyTests.DebuggerAttribute_NullCollection_ThrowsArgumentNullException
[01:53:09] info: Assert.Throws() Failure
[01:53:09] info: Expected: typeof(System.Reflection.TargetInvocationException)
[01:53:09] info: Actual:   typeof(System.InvalidOperationException): Expected one DebuggerTypeProxyAttribute on System.Collections.ObjectModel.ObservableCollection`1[System.Int32].
[01:53:09] info: ---- System.InvalidOperationException : Expected one DebuggerTypeProxyAttribute on System.Collections.ObjectModel.ObservableCollection`1[System.Int32].
[01:53:09] info:    at System.Diagnostics.DebuggerAttributes.GetProxyType(Type type, Type[] genericTypeArguments)
[01:53:09] info:    at System.Diagnostics.DebuggerAttributes.ValidateDebuggerTypeProxyProperties(Type type, Type[] genericTypeArguments, Object obj)
[01:53:09] info:    at System.Diagnostics.DebuggerAttributes.ValidateDebuggerTypeProxyProperties(Type type, Object obj)
[01:53:09] info:    at System.Collections.ObjectModel.Tests.ConstructorAndPropertyTests.<>c.<DebuggerAttribute_NullCollection_ThrowsArgumentNullException>b__11_0()
[01:53:09] info: ----- Inner Stack Trace -----
[01:53:09] info:    at System.Diagnostics.DebuggerAttributes.GetProxyType(Type type, Type[] genericTypeArguments)
[01:53:09] info:    at System.Diagnostics.DebuggerAttributes.ValidateDebuggerTypeProxyProperties(Type type, Type[] genericTypeArguments, Object obj)
[01:53:09] info:    at System.Diagnostics.DebuggerAttributes.ValidateDebuggerTypeProxyProperties(Type type, Object obj)
[01:53:09] info:    at System.Collections.ObjectModel.Tests.ConstructorAndPropertyTests.<>c.<DebuggerAttribute_NullCollection_ThrowsArgumentNullException>b__11_0()
[01:53:20] fail: [FAIL] System.Collections.ObjectModel.Tests.ObservableCollection_Serialization.OnDeserialized_MonitorNotInitialized_ExpectSuccess
[01:53:20] info: Assert.NotNull() Failure
[01:53:20] info:    at System.Collections.ObjectModel.Tests.ObservableCollection_Serialization.OnDeserialized_MonitorNotInitialized_ExpectSuccess()
[01:53:20] info:    at System.Reflection.RuntimeMethodInfo.Invoke(Object , BindingFlags , Binder , Object[] , CultureInfo )
[01:53:21] fail: [FAIL] System.Collections.ObjectModel.Tests.ReadOnlyObservableCollectionTests.DebuggerAttribute_Tests
[01:53:21] info: System.InvalidOperationException : Expected one DebuggerDisplayAttribute on System.Collections.ObjectModel.ReadOnlyObservableCollection`1[System.Int32].
[01:53:21] info:    at System.Diagnostics.DebuggerAttributes.ValidateDebuggerDisplayReferences(Object obj)
[01:53:21] info:    at System.Collections.ObjectModel.Tests.ReadOnlyObservableCollectionTests.DebuggerAttribute_Tests()
[01:53:21] info:    at System.Reflection.RuntimeMethodInfo.Invoke(Object , BindingFlags , Binder , Object[] , CultureInfo )
[01:53:21] fail: [FAIL] System.Collections.ObjectModel.Tests.ReadOnlyObservableCollectionTests.DebuggerAttribute_NullCollection_ThrowsArgumentNullException
[01:53:21] info: Assert.Throws() Failure
[01:53:21] info: Expected: typeof(System.Reflection.TargetInvocationException)
[01:53:21] info: Actual:   typeof(System.InvalidOperationException): Expected one DebuggerTypeProxyAttribute on System.Collections.ObjectModel.ReadOnlyObservableCollection`1[System.Int32].
[01:53:21] info: ---- System.InvalidOperationException : Expected one DebuggerTypeProxyAttribute on System.Collections.ObjectModel.ReadOnlyObservableCollection`1[System.Int32].
[01:53:21] info:    at System.Diagnostics.DebuggerAttributes.GetProxyType(Type type, Type[] genericTypeArguments)
[01:53:21] info:    at System.Diagnostics.DebuggerAttributes.ValidateDebuggerTypeProxyProperties(Type type, Type[] genericTypeArguments, Object obj)
[01:53:21] info:    at System.Diagnostics.DebuggerAttributes.ValidateDebuggerTypeProxyProperties(Type type, Object obj)
[01:53:21] info:    at System.Collections.ObjectModel.Tests.ReadOnlyObservableCollectionTests.<>c.<DebuggerAttribute_NullCollection_ThrowsArgumentNullException>b__10_0()
[01:53:21] info: ----- Inner Stack Trace -----
[01:53:21] info:    at System.Diagnostics.DebuggerAttributes.GetProxyType(Type type, Type[] genericTypeArguments)
[01:53:21] info:    at System.Diagnostics.DebuggerAttributes.ValidateDebuggerTypeProxyProperties(Type type, Type[] genericTypeArguments, Object obj)
[01:53:21] info:    at System.Diagnostics.DebuggerAttributes.ValidateDebuggerTypeProxyProperties(Type type, Object obj)
[01:53:21] info:    at System.Collections.ObjectModel.Tests.ReadOnlyObservableCollectionTests.<>c.<DebuggerAttribute_NullCollection_ThrowsArgumentNullException>b__10_0()
[01:53:21] info: Finished:    System.ObjectModel.Tests.dll
[01:53:21] info: 
[01:53:21] info: === TEST EXECUTION SUMMARY ===
[01:53:21] info: Total: 2152, Errors: 0, Failed: 8, Skipped: 4, Time: 24.01992s
Author: lewing
Assignees: -
Labels:

arch-wasm, area-System.Diagnostics, trimming-for-aot
Milestone: 7.0.0

@lewing lewing modified the milestones: 7.0.0, 8.0.0 Jul 25, 2022
@jkotas
Copy link
Member

jkotas commented Aug 4, 2022

We have PlatformDetection.IsDebuggerTypeProxyAttributeSupported. If it is not done already, it should get wired in for wasm and the tests marked with it [ConditionalTheory(typeof(PlatformDetection), nameof(PlatformDetection.IsDebuggerTypeProxyAttributeSupported))].

@jkotas
Copy link
Member

jkotas commented Aug 4, 2022 •
edited
Loading

Updating area label - the failing tests are under System.Collections.

@ghost
Copy link

ghost commented Aug 4, 2022

Tagging subscribers to this area: @dotnet/area-system-collections
See info in area-owners.md if you want to be subscribed.

Issue Details 
[01:53:09] fail: [FAIL] System.Collections.ObjectModel.Tests.ReadOnlyDictionaryTests.DebuggerAttribute_NullDictionary_ThrowsArgumentNullException
[01:53:09] info: Assert.Throws() Failure
[01:53:09] info: Expected: typeof(System.Reflection.TargetInvocationException)
[01:53:09] info: Actual:   typeof(System.InvalidOperationException): Expected one DebuggerTypeProxyAttribute on System.Collections.ObjectModel.ReadOnlyDictionary`2[System.Int32,System.Int32].
[01:53:09] info: ---- System.InvalidOperationException : Expected one DebuggerTypeProxyAttribute on System.Collections.ObjectModel.ReadOnlyDictionary`2[System.Int32,System.Int32].
[01:53:09] info:    at System.Diagnostics.DebuggerAttributes.GetProxyType(Type type, Type[] genericTypeArguments)
[01:53:09] info:    at System.Diagnostics.DebuggerAttributes.ValidateDebuggerTypeProxyProperties(Type type, Type[] genericTypeArguments, Object obj)
[01:53:09] info:    at System.Diagnostics.DebuggerAttributes.ValidateDebuggerTypeProxyProperties(Type type, Object obj)
[01:53:09] info:    at System.Collections.ObjectModel.Tests.ReadOnlyDictionaryTests.<>c.<DebuggerAttribute_NullDictionary_ThrowsArgumentNullException>b__13_0()
[01:53:09] info: ----- Inner Stack Trace -----
[01:53:09] info:    at System.Diagnostics.DebuggerAttributes.GetProxyType(Type type, Type[] genericTypeArguments)
[01:53:09] info:    at System.Diagnostics.DebuggerAttributes.ValidateDebuggerTypeProxyProperties(Type type, Type[] genericTypeArguments, Object obj)
[01:53:09] info:    at System.Diagnostics.DebuggerAttributes.ValidateDebuggerTypeProxyProperties(Type type, Object obj)
[01:53:09] info:    at System.Collections.ObjectModel.Tests.ReadOnlyDictionaryTests.<>c.<DebuggerAttribute_NullDictionary_ThrowsArgumentNullException>b__13_0()
[01:53:09] fail: [FAIL] System.Collections.ObjectModel.Tests.ReadOnlyDictionaryTests.DebuggerAttribute_NullDictionaryKeys_ThrowsArgumentNullException
[01:53:09] info: Assert.Throws() Failure
[01:53:09] info: Expected: typeof(System.Reflection.TargetInvocationException)
[01:53:09] info: Actual:   typeof(System.InvalidOperationException): Expected one DebuggerTypeProxyAttribute on System.Collections.ObjectModel.ReadOnlyDictionary`2+KeyCollection[System.Int32,System.Int32].
[01:53:09] info: ---- System.InvalidOperationException : Expected one DebuggerTypeProxyAttribute on System.Collections.ObjectModel.ReadOnlyDictionary`2+KeyCollection[System.Int32,System.Int32].
[01:53:09] info:    at System.Diagnostics.DebuggerAttributes.GetProxyType(Type type, Type[] genericTypeArguments)
[01:53:09] info:    at System.Diagnostics.DebuggerAttributes.ValidateDebuggerTypeProxyProperties(Type type, Type[] genericTypeArguments, Object obj)
[01:53:09] info:    at System.Collections.ObjectModel.Tests.ReadOnlyDictionaryTests.<>c.<DebuggerAttribute_NullDictionaryKeys_ThrowsArgumentNullException>b__14_0()
[01:53:09] info: ----- Inner Stack Trace -----
[01:53:09] info:    at System.Diagnostics.DebuggerAttributes.GetProxyType(Type type, Type[] genericTypeArguments)
[01:53:09] info:    at System.Diagnostics.DebuggerAttributes.ValidateDebuggerTypeProxyProperties(Type type, Type[] genericTypeArguments, Object obj)
[01:53:09] info:    at System.Collections.ObjectModel.Tests.ReadOnlyDictionaryTests.<>c.<DebuggerAttribute_NullDictionaryKeys_ThrowsArgumentNullException>b__14_0()
[01:53:09] fail: [FAIL] System.Collections.ObjectModel.Tests.ReadOnlyDictionaryTests.DebuggerAttributeTests
[01:53:09] info: System.InvalidOperationException : Expected one DebuggerDisplayAttribute on System.Collections.ObjectModel.ReadOnlyDictionary`2[System.Int32,System.Int32].
[01:53:09] info:    at System.Diagnostics.DebuggerAttributes.ValidateDebuggerDisplayReferences(Object obj)
[01:53:09] info:    at System.Collections.ObjectModel.Tests.ReadOnlyDictionaryTests.DebuggerAttributeTests()
[01:53:09] info:    at System.Reflection.RuntimeMethodInfo.Invoke(Object , BindingFlags , Binder , Object[] , CultureInfo )
[01:53:09] fail: [FAIL] System.Collections.ObjectModel.Tests.ConstructorAndPropertyTests.DebuggerAttributeTests
[01:53:09] info: System.InvalidOperationException : Expected one DebuggerDisplayAttribute on System.Collections.ObjectModel.ObservableCollection`1[System.Int32].
[01:53:09] info:    at System.Diagnostics.DebuggerAttributes.ValidateDebuggerDisplayReferences(Object obj)
[01:53:09] info:    at System.Collections.ObjectModel.Tests.ConstructorAndPropertyTests.DebuggerAttributeTests()
[01:53:09] info:    at System.Reflection.RuntimeMethodInfo.Invoke(Object , BindingFlags , Binder , Object[] , CultureInfo )
[01:53:09] fail: [FAIL] System.Collections.ObjectModel.Tests.ConstructorAndPropertyTests.DebuggerAttribute_NullCollection_ThrowsArgumentNullException
[01:53:09] info: Assert.Throws() Failure
[01:53:09] info: Expected: typeof(System.Reflection.TargetInvocationException)
[01:53:09] info: Actual:   typeof(System.InvalidOperationException): Expected one DebuggerTypeProxyAttribute on System.Collections.ObjectModel.ObservableCollection`1[System.Int32].
[01:53:09] info: ---- System.InvalidOperationException : Expected one DebuggerTypeProxyAttribute on System.Collections.ObjectModel.ObservableCollection`1[System.Int32].
[01:53:09] info:    at System.Diagnostics.DebuggerAttributes.GetProxyType(Type type, Type[] genericTypeArguments)
[01:53:09] info:    at System.Diagnostics.DebuggerAttributes.ValidateDebuggerTypeProxyProperties(Type type, Type[] genericTypeArguments, Object obj)
[01:53:09] info:    at System.Diagnostics.DebuggerAttributes.ValidateDebuggerTypeProxyProperties(Type type, Object obj)
[01:53:09] info:    at System.Collections.ObjectModel.Tests.ConstructorAndPropertyTests.<>c.<DebuggerAttribute_NullCollection_ThrowsArgumentNullException>b__11_0()
[01:53:09] info: ----- Inner Stack Trace -----
[01:53:09] info:    at System.Diagnostics.DebuggerAttributes.GetProxyType(Type type, Type[] genericTypeArguments)
[01:53:09] info:    at System.Diagnostics.DebuggerAttributes.ValidateDebuggerTypeProxyProperties(Type type, Type[] genericTypeArguments, Object obj)
[01:53:09] info:    at System.Diagnostics.DebuggerAttributes.ValidateDebuggerTypeProxyProperties(Type type, Object obj)
[01:53:09] info:    at System.Collections.ObjectModel.Tests.ConstructorAndPropertyTests.<>c.<DebuggerAttribute_NullCollection_ThrowsArgumentNullException>b__11_0()
[01:53:20] fail: [FAIL] System.Collections.ObjectModel.Tests.ObservableCollection_Serialization.OnDeserialized_MonitorNotInitialized_ExpectSuccess
[01:53:20] info: Assert.NotNull() Failure
[01:53:20] info:    at System.Collections.ObjectModel.Tests.ObservableCollection_Serialization.OnDeserialized_MonitorNotInitialized_ExpectSuccess()
[01:53:20] info:    at System.Reflection.RuntimeMethodInfo.Invoke(Object , BindingFlags , Binder , Object[] , CultureInfo )
[01:53:21] fail: [FAIL] System.Collections.ObjectModel.Tests.ReadOnlyObservableCollectionTests.DebuggerAttribute_Tests
[01:53:21] info: System.InvalidOperationException : Expected one DebuggerDisplayAttribute on System.Collections.ObjectModel.ReadOnlyObservableCollection`1[System.Int32].
[01:53:21] info:    at System.Diagnostics.DebuggerAttributes.ValidateDebuggerDisplayReferences(Object obj)
[01:53:21] info:    at System.Collections.ObjectModel.Tests.ReadOnlyObservableCollectionTests.DebuggerAttribute_Tests()
[01:53:21] info:    at System.Reflection.RuntimeMethodInfo.Invoke(Object , BindingFlags , Binder , Object[] , CultureInfo )
[01:53:21] fail: [FAIL] System.Collections.ObjectModel.Tests.ReadOnlyObservableCollectionTests.DebuggerAttribute_NullCollection_ThrowsArgumentNullException
[01:53:21] info: Assert.Throws() Failure
[01:53:21] info: Expected: typeof(System.Reflection.TargetInvocationException)
[01:53:21] info: Actual:   typeof(System.InvalidOperationException): Expected one DebuggerTypeProxyAttribute on System.Collections.ObjectModel.ReadOnlyObservableCollection`1[System.Int32].
[01:53:21] info: ---- System.InvalidOperationException : Expected one DebuggerTypeProxyAttribute on System.Collections.ObjectModel.ReadOnlyObservableCollection`1[System.Int32].
[01:53:21] info:    at System.Diagnostics.DebuggerAttributes.GetProxyType(Type type, Type[] genericTypeArguments)
[01:53:21] info:    at System.Diagnostics.DebuggerAttributes.ValidateDebuggerTypeProxyProperties(Type type, Type[] genericTypeArguments, Object obj)
[01:53:21] info:    at System.Diagnostics.DebuggerAttributes.ValidateDebuggerTypeProxyProperties(Type type, Object obj)
[01:53:21] info:    at System.Collections.ObjectModel.Tests.ReadOnlyObservableCollectionTests.<>c.<DebuggerAttribute_NullCollection_ThrowsArgumentNullException>b__10_0()
[01:53:21] info: ----- Inner Stack Trace -----
[01:53:21] info:    at System.Diagnostics.DebuggerAttributes.GetProxyType(Type type, Type[] genericTypeArguments)
[01:53:21] info:    at System.Diagnostics.DebuggerAttributes.ValidateDebuggerTypeProxyProperties(Type type, Type[] genericTypeArguments, Object obj)
[01:53:21] info:    at System.Diagnostics.DebuggerAttributes.ValidateDebuggerTypeProxyProperties(Type type, Object obj)
[01:53:21] info:    at System.Collections.ObjectModel.Tests.ReadOnlyObservableCollectionTests.<>c.<DebuggerAttribute_NullCollection_ThrowsArgumentNullException>b__10_0()
[01:53:21] info: Finished:    System.ObjectModel.Tests.dll
[01:53:21] info: 
[01:53:21] info: === TEST EXECUTION SUMMARY ===
[01:53:21] info: Total: 2152, Errors: 0, Failed: 8, Skipped: 4, Time: 24.01992s
Author: lewing
Assignees: -
Labels:

arch-wasm, area-System.Collections, area-System.Diagnostics, trimming-for-aot
Milestone: 8.0.0

@ilonatommy ilonatommy mentioned this issue Oct 21, 2022
Closed
@layomia layomia mentioned this issue Oct 24, 2022
Closed
14 tasks
@layomia
Copy link
Contributor

layomia commented May 25, 2023

@lewing @ilonatommy, any idea if this issue still occurs?

@layomia layomia added the needs-author-action An issue or pull request that requires more info or actions from the author. label May 25, 2023
@ghost
Copy link

ghost commented May 25, 2023

This issue has been marked needs-author-action and may be missing some important information.

@jkotas
Copy link
Member

jkotas commented May 25, 2023 •
edited
Loading

@lewing @ilonatommy, any idea if this issue still occurs?

Number of tests are disabled against this issue. You can re-enable them and see whether they pass.

@jkotas jkotas added the disabled-test The test is disabled in source code against the issue label May 25, 2023
@ghost ghost added the no-recent-activity label Jun 8, 2023
@ghost
Copy link

ghost commented Jun 8, 2023

This issue has been automatically marked no-recent-activity because it has not had any activity for 14 days. It will be closed if no further activity occurs within 14 more days. Any new comment (by anyone, not necessarily the author) will remove no-recent-activity.

@ghost
Copy link

ghost commented Jun 23, 2023

This issue will now be closed since it had been marked no-recent-activity but received no further activity in the past 14 days. It is still possible to reopen or comment on the issue, but please note that the issue will be locked if it remains inactive for another 30 days.

@ghost ghost closed this as completed Jun 23, 2023
@andrijana44
Copy link

#57588/

@ghost ghost removed the no-recent-activity label Jun 23, 2023
@jkotas
Copy link
Member

jkotas commented Jun 23, 2023 •
edited
Loading

We still have tests disabled against this issue.

@jkotas jkotas reopened this Jun 23, 2023
@jkotas jkotas removed the needs-author-action An issue or pull request that requires more info or actions from the author. label Jun 23, 2023
@ilonatommy
Copy link
Member

Still failing, I will take a look

@ilonatommy
Copy link
Member

ilonatommy commented Jul 24, 2023 •
edited
Loading

I do not see a point to expect from Activator.CreateInstance(proxyType, obj) to throw when obj == null. When obj is null then the Activator uses the "the constructor that takes no parameters (the parameterless constructor)" and ObservableCollection has a parentless one. From this reason I am changing the expected behavior in the tests to throw when customAttributes.Lentgh != 1 (in the failing tests it's 0).

edit: the change of exception type is not the right solution, instead we probably should not have 0 Length of custom attributes.

@lewing lewing closed this as completed Aug 4, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Sep 3, 2023
@kotlarmilos kotlarmilos changed the title [wasm][eat] System.Diagnostics trimming out DebuggerTypeProxyAttribute. [trimming] System.Diagnostics trimming out DebuggerTypeProxyAttribute. Mar 12, 2024
@kotlarmilos kotlarmilos added the os-ios Apple iOS label Mar 12, 2024
@kotlarmilos kotlarmilos modified the milestones: 8.0.0, Future Mar 12, 2024
@kotlarmilos kotlarmilos reopened this Mar 21, 2024
@kotlarmilos
Copy link
Member

The failures are still relevant.

@lewing lewing assigned thaystg and unassigned ilonatommy Mar 23, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees

@thaystg thaystg

Labels
arch-wasm WebAssembly architecture area-System.Collections disabled-test The test is disabled in source code against the issue os-ios Apple iOS test-failure trimming-for-aot `EnableAggressiveTrimming=true` used for running tests with AOT
Projects
None yet
Milestone
Future
Development

No branches or pull requests
9 participants
@lewing @eiriktsarpalis @thaystg @jkotas @jeffschwMSFT @layomia @kotlarmilos @ilonatommy @andrijana44