Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Track unknown value as result of unimplemented operations #101752

Merged
merged 3 commits into from
May 1, 2024
Merged

Track unknown value as result of unimplemented operations #101752

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8fe695d
Add testcase
sbomer Apr 30, 2024
72a7e70
Merge remote-tracking branch 'origin/main' into interpolatedStringFix
sbomer Apr 30, 2024
4835d6a
Track unknown return value for unimplemented operations
sbomer Apr 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions src/tools/illink/src/ILLink.RoslynAnalyzer/TrimAnalysis/TrimAnalysisVisitor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,16 +75,22 @@ public override void ApplyCondition (FeatureChecksValue featureChecksValue, ref
// - 'this' parameter (for annotated methods)
// - field reference

public override MultiValue Visit (IOperation? operation, StateValue argument)
public override MultiValue DefaultVisit (IOperation operation, StateValue argument)
{
var returnValue = base.Visit (operation, argument);
var returnValue = base.DefaultVisit (operation, argument);

// If the return value is empty (TopValue basically) and the Operation tree
// reports it as having a constant value, use that as it will automatically cover
// cases we don't need/want to handle.
if (operation != null && returnValue.IsEmpty () && TryGetConstantValue (operation, out var constValue))
if (!returnValue.IsEmpty ())
return returnValue;

if (TryGetConstantValue (operation, out var constValue))
return constValue;

if (operation.Type is not null)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does it mean when it's null vs nonnull? A comment here might be helpful if it's not in the doc comments for IOperation.Type.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Null just means it doesn't produce a result: https://learn.microsoft.com/dotnet/api/microsoft.codeanalysis.ioperation.type?view=roslyn-dotnet-4.7.0#microsoft-codeanalysis-ioperation-type

return UnknownValue.Instance;

return returnValue;
}

Expand Down
2 changes: 1 addition & 1 deletion src/tools/illink/test/ILLink.RoslynAnalyzer.Tests/DataFlowTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ public Task InlineArrayDataflow ()
}

[Fact]
public Task InterpolatedStringHandlerDataFlow ()
public Task InterpolatedStringDataFlow ()
{
return RunTest ();
}
Expand Down
8 changes: 6 additions & 2 deletions src/tools/illink/test/ILLink.RoslynAnalyzer.Tests/DynamicallyAccessedMembersAnalyzerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1309,7 +1309,9 @@ public static void Main()

return VerifyDynamicallyAccessedMembersAnalyzer (Source, consoleApplication: false,
// (12,34): error CS0103: The name 'type' does not exist in the current context
DiagnosticResult.CompilerError ("CS0103").WithSpan (12, 34, 12, 38).WithArguments ("type"));
DiagnosticResult.CompilerError ("CS0103").WithSpan (12, 34, 12, 38).WithArguments ("type"),
// (12,34): warning IL2063: Value returned from method 'C.GetTypeWithAll()' can not be statically determined and may not meet 'DynamicallyAccessedMembersAttribute' requirements.
VerifyCS.Diagnostic (DiagnosticId.MethodReturnValueCannotBeStaticallyDetermined).WithSpan(12, 34, 12, 38).WithArguments("C.GetTypeWithAll()"));
}

[Fact]
Expand All @@ -1333,7 +1335,9 @@ public static void Main()

return VerifyDynamicallyAccessedMembersAnalyzer (Source, consoleApplication: false,
// (8,22): error CS0103: The name 'type' does not exist in the current context
DiagnosticResult.CompilerError ("CS0103").WithSpan (8, 22, 8, 26).WithArguments ("type"));
DiagnosticResult.CompilerError ("CS0103").WithSpan (8, 22, 8, 26).WithArguments ("type"),
// (8,3): warning IL2064: Value assigned to C.fieldRequiresAll can not be statically determined and may not meet 'DynamicallyAccessedMembersAttribute' requirements.
VerifyCS.Diagnostic(DiagnosticId.FieldValueCannotBeStaticallyDetermined).WithSpan(8, 3, 8, 26).WithArguments("C.fieldRequiresAll"));
}

[Fact]
Expand Down
12 changes: 9 additions & 3 deletions ...Flow/InterpolatedStringHandlerDataFlow.cs → ...es/DataFlow/InterpolatedStringDataFlow.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,15 @@ namespace Mono.Linker.Tests.Cases.DataFlow
[ExpectedNoWarnings]
[SkipKeptItemsValidation]
[Define ("DEBUG")]
public class InterpolatedStringHandlerDataFlow
public class InterpolatedStringDataFlow
{
public static void Main ()
{
Test ();
TestInterpolatedStringHandler ();
TestUnknownInterpolatedString ();
}

static void Test(bool b = true) {
static void TestInterpolatedStringHandler (bool b = true) {
// Creates a control-flow graph for the analyzer that has an
// IFlowCaptureReferenceOperation that represents a capture
// because it is used as an out param (so has IsInitialization = true).
Expand All @@ -31,5 +32,10 @@ static void Test(bool b = true) {
// where IsInitialization = true.
Debug.Assert (b, $"Debug interpolated string handler {b}");
}

[ExpectedWarning ("IL2057")]
static void TestUnknownInterpolatedString (string input = "test") {
Type.GetType ($"{input}");
}
}
}
Loading