Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Arm64/Sve: Implement Math's DotProduct* APIs #102218

Merged
merged 8 commits into from
May 15, 2024
Merged

Arm64/Sve: Implement Math's DotProduct* APIs #102218

merged 8 commits into from
May 15, 2024

Conversation

kunalspathak
Copy link
Member

@kunalspathak kunalspathak commented May 14, 2024 •
edited
Loading

  • DotProduct
  • DotProductBySelectedScalar

I have also fixed MultiplyBySelectedScalar to make sure that it uses low vector registers.

All tests are passing: https://gist.github.com/kunalspathak/ada97d38ae4e104b1fa7112a48937bd1

Contributes to #99957

@dotnet-issue-labeler dotnet-issue-labeler bot added area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI new-api-needs-documentation labels May 14, 2024
@dotnet-issue-labeler dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@kunalspathak kunalspathak added the arm-sve Work related to arm64 SVE/SVE2 support label May 14, 2024
@kunalspathak kunalspathak mentioned this pull request May 14, 2024
Closed
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@kunalspathak
Copy link
Member Author

@dotnet/arm64-contrib

@kunalspathak kunalspathak requested a review from TIHan May 14, 2024 22:40
This was referenced May 15, 2024
Open
Closed
Closed
This was referenced May 15, 2024
Open
Closed
@kunalspathak
Copy link
Member Author

/ba-g the timeout seems to be because of #102239

@kunalspathak kunalspathak merged commit 60edf5b into dotnet:main May 15, 2024
159 of 167 checks passed
@kunalspathak kunalspathak deleted the sve_math8 branch May 15, 2024 23:38
Ruihan-Yin pushed a commit to Ruihan-Yin/runtime that referenced this pull request May 30, 2024
@kunalspathak @Ruihan-Yin
Arm64/Sve: Implement Math's DotProduct* APIs (dotnet#102218)
6d423fd 
* Add DotProduct() and DotProductBySelectedScalar() APIs

* Map API to instruction

* Fix test cases

* Make DotProductBySelectedScalar work

* Fix mov unit tests

* Add LowVector flag

* jit format

* fix the build error
@github-actions github-actions bot locked and limited conversation to collaborators Jun 15, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@tannergooding tannergooding tannergooding approved these changes

@TIHan TIHan Awaiting requested review from TIHan

Assignees

@kunalspathak kunalspathak

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI arm-sve Work related to arm64 SVE/SVE2 support new-api-needs-documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kunalspathak @tannergooding