Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[wasm] Fix emsdk check #103027

Merged
merged 1 commit into from
Jun 6, 2024
Merged

Conversation

radekdoulik
Copy link
Member

We use system python on osx too

We use system python on osx too
@radekdoulik
Copy link
Member Author

@mkhamoyan please check that it fixes the issue with the sample build for you

@mkhamoyan
Copy link
Contributor

@mkhamoyan please check that it fixes the issue with the sample build for you

@radekdoulik yes this fixed the issue, thanks!

@akoeplinger
Copy link
Member

We use system python on osx too

That's not what we intended, we should use our own python on osx and windows. Only Linux uses the system python.

@radekdoulik
Copy link
Member Author

We use system python on osx too

That's not what we intended, we should use our own python on osx and windows. Only Linux uses the system python.

do you remember what is the reason?

I think it might have changed in #100266

@akoeplinger
Copy link
Member

akoeplinger commented Jun 5, 2024

MacOS doesn't ship with Python anymore, you probably just have it installed from homebrew like I do.
We need to fix whatever got broken to use the Python packages that we build.

@radekdoulik
Copy link
Member Author

Let's merge it for now. I have opened new issue to not forget about it. #103120

@radekdoulik radekdoulik merged commit 87ca274 into dotnet:main Jun 6, 2024
31 of 34 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 7, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants