Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add Gauge Metrics Instrument #103543

Merged
merged 3 commits into from
Jun 19, 2024
Merged

Add Gauge Metrics Instrument #103543

merged 3 commits into from
Jun 19, 2024

Conversation

tarekgh
Copy link
Member

@tarekgh tarekgh commented Jun 16, 2024

Fixes #92625

@dotnet-issue-labeler dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

1 similar comment
@dotnet-issue-labeler dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@tarekgh tarekgh added this to the 9.0.0 milestone Jun 16, 2024
@tarekgh
Copy link
Member Author

tarekgh commented Jun 16, 2024

CC @noahfalk @reyang @cijothomas @CodeBlanch

@tarekgh
Copy link
Member Author

tarekgh commented Jun 16, 2024

/azp run runtime-libraries-coreclr outerloop

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Jun 16, 2024
Closed
Open
Closed
noahfalk
noahfalk approved these changes Jun 18, 2024
View reviewed changes
Copy link
Member

@noahfalk noahfalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than a few nits in the doc comments. Thanks 👍

@tarekgh @cijothomas
Apply suggestions from code review
0915a4f 
Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
This was referenced Jun 19, 2024
Open
Open
Closed
@tarekgh tarekgh merged commit c529580 into dotnet:main Jun 19, 2024
70 of 81 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 19, 2024
@tarekgh tarekgh deleted the AddGaugeMetricsInstrument branch August 6, 2024 20:04
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@cijothomas cijothomas cijothomas left review comments

@noahfalk noahfalk noahfalk approved these changes

Assignees

@tarekgh tarekgh

Labels
area-System.Diagnostics.Metric new-api-needs-documentation
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Add synchronous gauge instrument
3 participants
@tarekgh @cijothomas @noahfalk