[wasm] Fix mono_wasm_load_runtime cwrap signature #104356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: `Uncaught ExitStatus: Assertion failed: stringToUTF8Array expects a string (got number)`
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Tagging subscribers to this area: @directhex, @matouskozak |
|
could you please also unify it in WASI, to drop the first un-used parameter of |
pavelsavara
approved these changes
Jul 3, 2024
This was referenced Jul 3, 2024
Open
radekdoulik
added a commit
to radekdoulik/runtime
that referenced
this pull request
Jul 9, 2024
This was referenced Jul 9, 2024
matouskozak
added a commit
to matouskozak/runtime
that referenced
this pull request
Jul 11, 2024
)" This reverts commit ddd9617.
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
Uncaught ExitStatus: Assertion failed: stringToUTF8Array expects a string (got number)Context: this is not visible with current emscripten, it fails with newer emscripten 3.1.56