Add DI specification test for ensuring externally provided instance services are not disposed on provider disposal.

[alistairjevans]

Fixes #102651

[alistairjevans]

Looks like the external container tests are failing, which they will until we fix the behaviour I'm testing for in Autofac! What's the approach here, fix Autofac before merging, and update the external tests project? Or mark the new test as skipped for Autofac to get this merged?

[steveharter]

Looks like the external container tests are failing, which they will until we fix the behaviour I'm testing for in Autofac! What's the approach here, fix Autofac before merging, and update the external tests project? Or mark the new test as skipped for Autofac to get this merged?

It depends on timing. If the Autofac fix is coming soon, I'd wait and then update the version in the Microsoft.Extensions.DependencyInjection.ExternalContainers.Tests project:

    <PackageReference Include="Autofac.Extensions.DependencyInjection" Version="8.0.0" />

If it will be a while, then use

[ActiveIssue("https://github.com/dotnet/runtime/issues/102651")]

on the test.

[alistairjevans]

We'll get an Autofac release out with the fix first; shouldn't be long.

[alistairjevans]

@steveharter, the updated package is up, 10.0.0, and I've updated the project. Some of the checks claim not to be able to find the new version though. Anything needs to be updated or cache flushed?

[steveharter]

@steveharter, the updated package is up, 10.0.0, and I've updated the project. Some of the checks claim not to be able to find the new version though. Anything needs to be updated or cache flushed?

@alistairjevans can you sync with main please. Autofac was updated to 10 recently here: #107639. Thanks

[steveharter]

Note after the recent merge from main, this PR only has the new test ServiceInstanceAreNotDisposedWhenTheProviderIsDisposed

[steveharter]

@alistairjevans the new test is failing; the service is being disposed.

From the issue:

In the MS DI implementation, it is stated in docs that services not created by the service container are not disposed of when the application instance stops.

However from the docs is states that registered singletons are disposed:

The container calls Dispose for the IDisposable types it creates. Services resolved from the container should never be disposed by the developer. If a type or factory is registered as a singleton, the container disposes the singleton automatically.

[dotnet-policy-service]

This pull request has been automatically marked no-recent-activity because it has not had any activity for 14 days. It will be closed if no further activity occurs within 14 more days. Any new comment (by anyone, not necessarily the author) will remove no-recent-activity.

[dotnet-policy-service]

This pull request will now be closed since it had been marked no-recent-activity but received no further activity in the past 14 days. It is still possible to reopen or comment on the pull request, but please note that it will be locked if it remains inactive for another 30 days.