-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[browser] Remove check for user agent when attaching debugger #105559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't like this check for PDB to decide the debug level because the customer should be able to use embedded pdbs? |
This was referenced Jul 26, 2024
This was referenced Jul 29, 2024
This was referenced Aug 2, 2024
This was referenced Aug 5, 2024
This was referenced Aug 8, 2024
I think that this change enables debugging on NodeJS, could you please test that it also works ? |
pavelsavara
approved these changes
Aug 9, 2024
No, managed debugging doesn't work on NodeJS |
@maraf this appears to have turned off all optimizations on v8? dotnet/perf-autofiling-issues#39876 |
lewing
added a commit
that referenced
this pull request
Aug 16, 2024
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DebugLevel != 0
Fixes #104234