Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add documentation for VBS in CngKeyCreationOptions #107301

Merged
merged 3 commits into from
Sep 3, 2024

Conversation

vcsjones
Copy link
Member

@vcsjones vcsjones commented Sep 3, 2024

This is more or less a repeat of the Win32 docs, trimmed down a bit.

@vcsjones vcsjones added the documentation Documentation bug or enhancement, does not impact product or test code label Sep 3, 2024
@vcsjones vcsjones requested review from krwq and bartonjs September 3, 2024 16:15
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones
See info in area-owners.md if you want to be subscribed.

Co-authored-by: Jeremy Barton <jbarton@microsoft.com>
Comment on lines +30 to +31
/// Instructs Virtualization-based security (VBS) to protect the client key with a per-boot key
/// when combined with <see cref="RequireVbs"/> or <see cref="PreferVbs"/> .
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// Instructs Virtualization-based security (VBS) to protect the client key with a per-boot key
/// when combined with <see cref="RequireVbs"/> or <see cref="PreferVbs"/> .
/// Instructs Virtualization-based security (VBS) to protect the client key with a key that can't
/// be reused across boot cycles when combined with <see cref="RequireVbs"/> or
/// <see cref="PreferVbs"/>.

@vcsjones vcsjones merged commit 747df88 into dotnet:main Sep 3, 2024
80 of 85 checks passed
@vcsjones vcsjones deleted the add-cng-key-vbs-docs branch September 4, 2024 15:38
@github-actions github-actions bot locked and limited conversation to collaborators Oct 6, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
area-System.Security documentation Documentation bug or enhancement, does not impact product or test code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants