Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Provide System.CodeDom package readme #107372

Merged
merged 3 commits into from
Sep 11, 2024
Merged

Conversation

eNeRGy164
Copy link
Contributor

Fill out details for the System.CodeDom NuGet package readme.

See #99358

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Sep 4, 2024
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-codedom
See info in area-owners.md if you want to be subscribed.

@teo-tsirpanis
Copy link
Contributor

Should it say that CodeDom is superseded by Roslyn?

@steveharter
Copy link
Member

Should it say that CodeDom is superseded by Roslyn?

I think it would good to mentioned that for new work, Roslyn should be used (in general, if you don't need CodeDom-specific functionality). Also, we have the readme.md file -- perhaps that would be a better place or an additional place for that statement.

@buyaa-n
Copy link
Contributor

buyaa-n commented Sep 11, 2024

The changes looks good once the feedback about Roslyn is resolved

@eNeRGy164 eNeRGy164 requested a review from buyaa-n September 11, 2024 07:50
Copy link
Contributor

@buyaa-n buyaa-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks you!

@buyaa-n buyaa-n merged commit c381595 into dotnet:main Sep 11, 2024
82 of 86 checks passed
@eNeRGy164 eNeRGy164 deleted the system-codedom branch September 11, 2024 20:25
buyaa-n added a commit to buyaa-n/runtime that referenced this pull request Sep 11, 2024
* Provide System.CodeDom package readme

* Add remark about Roslyn/.NET Compiler SDK

* Update src/libraries/System.CodeDom/src/PACKAGE.md

---------

Co-authored-by: Buyaa Namnan <buyankhishig.namnan@microsoft.com>
carlossanlop pushed a commit that referenced this pull request Sep 12, 2024
* Provide System.Composition package readme (#106443)

* Provide System.Composition package readme

* Fix empty lines

* Provide System.Composition.AttributedModel package readme (#106781)

* Provide System.Composition.AttributedModel package readme

* Improve after feedback

* Set correct PackageDescription

* Provide System.Composition.Convention package readme (#106782)

* Provide System.Composition.Convention package readme

* Improve after feedback

* Provide System.Composition.Hosting package readme (#106783)

* Provide System.Composition.Hosting package readme

* Improve after feedback

* Provide System.Composition.Runtime package readme (#106784)

* Provide System.Composition.Runtime package readme

* Improve after feedback

* Provide System.Composition.TypedParts package readme (#106785)

* Provide System.Composition.TypedParts package readme

* Improve after feedback

* Provide System.CodeDom package readme (#107372)

* Provide System.CodeDom package readme

* Add remark about Roslyn/.NET Compiler SDK

* Update src/libraries/System.CodeDom/src/PACKAGE.md

---------

Co-authored-by: Buyaa Namnan <buyankhishig.namnan@microsoft.com>

---------

Co-authored-by: Michaël Hompus <michael@hompus.nl>
jtschuster pushed a commit to jtschuster/runtime that referenced this pull request Sep 17, 2024
* Provide System.CodeDom package readme

* Add remark about Roslyn/.NET Compiler SDK

* Update src/libraries/System.CodeDom/src/PACKAGE.md

---------

Co-authored-by: Buyaa Namnan <buyankhishig.namnan@microsoft.com>
sirntar pushed a commit to sirntar/runtime that referenced this pull request Sep 30, 2024
* Provide System.CodeDom package readme

* Add remark about Roslyn/.NET Compiler SDK

* Update src/libraries/System.CodeDom/src/PACKAGE.md

---------

Co-authored-by: Buyaa Namnan <buyankhishig.namnan@microsoft.com>
@github-actions github-actions bot locked and limited conversation to collaborators Oct 12, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
area-System.CodeDom community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants