-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[debugger] Throw with short and easily caught message in debugger tests. #109011
Conversation
Tagging subscribers to this area: @thaystg |
Tagging subscribers to 'arch-wasm': @lewing |
src/mono/browser/debugger/DebuggerTestSuite/DebuggerTestBase.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Marek Fišera <mara@neptuo.com>
Generally on this PR it works but we still have logs like:
Maybe it's also coming from |
Based on a few logs that had failures connected with
internal virtual async Task<JObject> WaitFor(string what)
, e.g.:The logs that look like this:
https://dotnet.github.io/core-eng/helix-workitem-deadletter.txt
might be created due to too long logs. Typically,
WaitFor
throws with logging a long json text. If we would catch that error and rephrase it, it will be easier forKnown Issue
to catch the logs. The debugger tests are due to be migrated soon, so loosing the details about the json that is logged should not be a problem.