Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[debugger] Throw with short and easily caught message in debugger tests. #109011

Merged
merged 5 commits into from
Oct 18, 2024

Conversation

ilonatommy
Copy link
Member

Based on a few logs that had failures connected with internal virtual async Task<JObject> WaitFor(string what), e.g.:

The logs that look like this:
https://dotnet.github.io/core-eng/helix-workitem-deadletter.txt

If you’re reading this, that means the Helix work item you’re trying to find the logs for has dead-lettered.

What this means:

- All attempts to retry execution of this work item were unable to complete.  This can be both for infrastructure reasons (problems within Azure) or issues with the work item (for instance, causing a machine to reboot unexpectedly or killing the Helix client on the machine will force a retry).
- No further work will be done for this specific work item, and its exit code is set to an artificial -1 (since it did not complete, there is no real exit code).
...etc

might be created due to too long logs. Typically, WaitFor throws with logging a long json text. If we would catch that error and rephrase it, it will be easier for Known Issue to catch the logs. The debugger tests are due to be migrated soon, so loosing the details about the json that is logged should not be a problem.

Copy link
Contributor

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

Copy link
Contributor

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Co-authored-by: Marek Fišera <mara@neptuo.com>
@ilonatommy
Copy link
Member Author

Generally on this PR it works but we still have logs like:
https://helixre107v0xdcypoyl9e7f.blob.core.windows.net/dotnet-runtime-refs-pull-109011-merge-7b8a8a12269040d59f/chrome-DebuggerTests.GetPropertiesTests/1/console.dd12fe20.log?helixlogtype=result

Starting test execution, please wait...
A total of 1 test files matched the specified pattern.

...
[EXECUTION TIMED OUT]
Exit Code:-3Executor timed out after 3000 seconds and was killed

['chrome-DebuggerTests.GetPropertiesTests' END OF WORK ITEM LOG: Command timed out, and was killed]

Maybe it's also coming from WaitFor but does not manage to throw exception? Just to be sure, I will add a timeout in that method, let's say 10 sec per one WaitFor.

@ilonatommy ilonatommy merged commit ea34695 into dotnet:main Oct 18, 2024
16 of 19 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 18, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
arch-wasm WebAssembly architecture area-Debugger-mono
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants