Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update Roslyn to 4.13.0-1.24510.9 #109467

Merged
merged 8 commits into from
Nov 2, 2024
Merged

Conversation

am11
Copy link
Member

@am11 am11 commented Nov 1, 2024

Based on #108789.
Resolve VMR failures seen in dotnet/sdk#43015

@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Nov 1, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Nov 1, 2024
@am11 am11 added area-Infrastructure and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Nov 1, 2024
Copy link
Contributor

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

@@ -380,17 +380,17 @@
<Uri>https://github.com/dotnet/runtime-assets</Uri>
<Sha>8254bfd574d0f7a89450a2e191d9e9f3dfb8ad59</Sha>
</Dependency>
<Dependency Name="Microsoft.Net.Compilers.Toolset" Version="4.12.0-3.24523.10">
<Dependency Name="Microsoft.Net.Compilers.Toolset" Version="4.13.0-2.24531.4">
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@am11 am11 force-pushed the feature/roslyn-updates branch from dfa1ca0 to 107202c Compare November 1, 2024 21:45
@ViktorHofer
Copy link
Member

/ba-g hanging browser tests and unrelated browser test failures

@ViktorHofer ViktorHofer merged commit 1e41404 into dotnet:main Nov 2, 2024
153 of 159 checks passed
@am11 am11 deleted the feature/roslyn-updates branch November 2, 2024 09:14
jkotas added a commit that referenced this pull request Nov 4, 2024
@jkotas
Copy link
Member

jkotas commented Nov 4, 2024

It appears that this PR introduced hangs/timeouts in CLR_Tools_Tests. CLR_Tools_Tests is failing with hang/timeout in all PRs. I am validating whether the CLR_Tools_Tests hang/timeout goes away in #109495.

@am11
Copy link
Member Author

am11 commented Nov 4, 2024

@sbomer
Copy link
Member

sbomer commented Nov 4, 2024

https://dev.azure.com/dnceng-public/public/_build/results?buildId=858785&view=results is the first one I see that has the timeout. The diff with the previous build is 598d5f7...275ea58 - I think #109392 is the culprit. Reverting in #109520.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
area-Infrastructure community-contribution Indicates that the PR has been added by a community member
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants