Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[release/9.0-staging] fix stack 2x2 tensor along dimension 1 #110053

Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Nov 21, 2024

Backport of #108620 to release/9.0-staging

/cc @tannergooding @kasperk81

Customer Impact

  • Customer reported
  • Found internally

#108615. Incorrect results will be computed for StackAlongDimension

Regression

  • Yes
  • No

This is a net new and in-preview API for .NET 9

Testing

Additional tests covering the relevant scenario were added.

Risk

Low. This is a net new API in .NET 9 and shipped as experimental.

Fixing it will help ensure developers can use the feature and provide feedback as part of stabilizing the API surface.

Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-numerics-tensors
See info in area-owners.md if you want to be subscribed.

@tannergooding tannergooding added the Servicing-consider Issue for next servicing release review label Nov 21, 2024
@tannergooding
Copy link
Member

CC. @jeffhandley

Copy link
Member

@jeffhandley jeffhandley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI @artl93

@tannergooding
Copy link
Member

Removed servicing-consider temporarily as @MihaZupan pointed out that another line needs updating for the latter method to be correct. This likely means we also need another test to cover that overload

@carlossanlop
Copy link
Member

@tannergooding @jeffhandley friendly reminder that today's code complete for the Feb 2025 Release. Please merge this change by 4pm PT if you'd like it included in that release version. Otherwise, it will have to wait until next month.

@tannergooding
Copy link
Member

@michaelgsharp is looking into the other issue that is pending

@michaelgsharp
Copy link
Member

@tannergooding @carlossanlop fix is pushed. I know code complete is now tomorrow AM so hopefully this can still get in.

@carlossanlop
Copy link
Member

Make sure to get a Tactics approval.

Copy link
Member

@ericstj ericstj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks to combine #108620 and #111390

@ericstj
Copy link
Member

ericstj commented Jan 27, 2025

/azp run runtime

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ericstj ericstj added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Jan 28, 2025
@ericstj
Copy link
Member

ericstj commented Jan 28, 2025

Approved over mail.

@michaelgsharp michaelgsharp merged commit db5ef46 into release/9.0-staging Jan 28, 2025
81 of 87 checks passed
@michaelgsharp michaelgsharp deleted the backport/pr-108620-to-release/9.0-staging branch January 28, 2025 00:32
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants