Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Delete dead code in ilasm PE writer #111218

Merged
merged 5 commits into from
Jan 17, 2025
Merged

Delete dead code in ilasm PE writer #111218

merged 5 commits into from
Jan 17, 2025

Conversation

jkotas
Copy link
Member

@jkotas jkotas commented Jan 8, 2025

No description provided.

@jkotas
Copy link
Member Author

jkotas commented Jan 8, 2025

Follow up on #111212

@jkotas jkotas added area-Tools-ILLink .NET linker development as well as trimming analyzers area-ILTools-coreclr and removed area-VM-coreclr area-Tools-ILLink .NET linker development as well as trimming analyzers labels Jan 8, 2025
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Copy link
Member

@AaronRobinsonMSFT AaronRobinsonMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Run the IL roundtrip legs?

@jkotas
Copy link
Member Author

jkotas commented Jan 16, 2025

/azp run runtime-coreclr ilasm

Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@jkotas jkotas merged commit 16b17d8 into dotnet:main Jan 17, 2025
92 checks passed
@jkotas jkotas deleted the deadcode branch January 17, 2025 00:11
grendello added a commit to grendello/runtime that referenced this pull request Jan 20, 2025
* main: (89 commits)
  Add Dispose for X509Chain instance (dotnet#110740)
  Fix XML comment on regex split enumerator (dotnet#111572)
  JIT: tolerate missing InitClass map in SPMI (dotnet#111555)
  Build ilasm/ildasm packages for the host machine (dotnet#111512)
  Unicode 16.0 Support (dotnet#111469)
  Improve performance of interface method resolution in ILC (dotnet#103066)
  Fix building the host-targeting components and packing ILC (dotnet#111552)
  Improve JSON validation perf (dotnet#111332)
  Update github-merge-flow.jsonc to autoflow 9.0 to 9.0-staging (dotnet#111549)
  Include GPL-3 licence text in the notice (dotnet#111528)
  Remove explicit __compact_unwind entries from x64 assembler (dotnet#111530)
  Add MemoryExtensions overloads with comparer (dotnet#110197)
  Avoid capturing the ExecutionContext for the whole HTTP connection lifetime (dotnet#111475)
  Forward DefaultArtifactVisibility down from the VMR orchestrator (dotnet#111513)
  Fix relocs errors on riscv64 (dotnet#111317)
  Added JITDUMP_USE_ARCH_TIMESTAMP support. (dotnet#111359)
  add rcl/rcr tp and latency info (dotnet#111442)
  Fix stack overflow in compiler-generated state (dotnet#109207)
  Produce a package with the host-running ILC for repos in the VMR (dotnet#111443)
  Delete dead code in ilasm PE writer (dotnet#111218)
  ...
@github-actions github-actions bot locked and limited conversation to collaborators Feb 16, 2025
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants