Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

JIT: Set PGO data inconsistent when flow disappears in cast expansion #112147

Merged
merged 2 commits into from
Feb 5, 2025
Merged

JIT: Set PGO data inconsistent when flow disappears in cast expansion #112147

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
91925b5
JIT: Set PGO data inconsistent when flow disappears in cast expansion
jakobbotsch Feb 4, 2025
3e2f82f
Reorder
jakobbotsch Feb 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/coreclr/jit/helperexpansion.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2729,6 +2729,14 @@ bool Compiler::fgLateCastExpansionForCall(BasicBlock** pBlock, Statement* stmt,
}
}

if (fallbackBb->KindIs(BBJ_THROW) && (fallbackBb->bbWeight != BB_ZERO_WEIGHT))
{
// This flow is disappearing.
JITDUMP("fgLateCastExpansionForCall: fallback " FMT_BB " throws and has flow into it. Data %s inconsistent.\n",
fallbackBb->bbNum, fgPgoConsistent ? "is now" : "was already");
fgPgoConsistent = false;
}

// Bonus step: merge prevBb with nullcheckBb as they are likely to be mergeable
if (fgCanCompactBlock(firstBb))
{
Expand Down
Loading